-
Notifications
You must be signed in to change notification settings - Fork 735
[css-animations-2] [web-animations-2] Animation trigger event #12314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 11 commits
b14d0a8
a00f16c
e3c4860
146b2be
45d4ec4
61ebaf3
fc36f37
b76c534
8b88211
f3652ba
a26f516
b1a5920
172ebc9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -770,6 +770,8 @@ for an [=animation trigger=] that enters its [=animation trigger/active interval | |
|
||
The behavior of each value is defined in [[web-animations-2#trigger-behaviors]]. | ||
|
||
Issue: Should 'animation-trigger-behavior' allow multiple values (currently it does)? | ||
|
||
## The 'animation-trigger-timeline' property ## {#animation-trigger-timeline} | ||
|
||
The 'animation-trigger-timeline' property specifies the <a>timeline</a> | ||
|
@@ -962,18 +964,70 @@ The values of 'animation-trigger-exit-range-start' have the following meaning: | |
it defaults to 100%. | ||
</dl> | ||
|
||
## The 'animation-trigger-name' property ## {#animation-trigger-name} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If this property is not a longhand sub-property of
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. After discussion with @flackr and @DavMila, I think the plan is to use a scoping mechanism similar to anchor positioning -- specifically, there will be a The name is only used to specify the event target; the event type is specified via I will change the property to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK, I still think that the type should be part of the event declaration on the target. |
||
|
||
The 'animation-trigger-name' property associates an element with | ||
all elements having an 'animation-trigger-event' property with | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it's not accurate to say we "associate elements". The event needs to be associated with a target, and the target here is an animation(s). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't quite follow you here, but I will point out firstly that the term "target" appears to be overloaded here. Because we're working with events, and "event target" is a very well-understood concept, I'm using the term "target" to refer to the event target and not the element that will animate. There is definitely an "association" happening here:
If a Is there some other term besides "association" that better describes the relationships between these elements? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because we have 2 elements in play here, I was trying to use "source" for the event target, and "target" for the animated element, but let's stick with event target. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see your point; I re-worded this in terms of creating an animation trigger for animations on elements having a matching |
||
a trigger name matching a value in this element's 'animation-trigger-name'. | ||
When an {{Event}} is dispatched with this element as {{Event/target}}, | ||
and with {{Event/type}} matching the <<trigger-event-type>> of a clause in the | ||
'animation-trigger-event' property of another element, animation | ||
playback on the other element is modified according to its | ||
'animation-trigger-behavior' property, as described for | ||
[=event-based animation triggers=]. | ||
|
||
<pre class='propdef'> | ||
Name: animation-trigger-name | ||
Value: none | [ <<trigger-name>> ]# | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If this property has no other sub-properties, why does it need to be a list? |
||
Initial: none | ||
Applies to: all elements | ||
Inherited: no | ||
Percentages: N/A | ||
Computed value: as specified | ||
Animation type: not animatable | ||
</pre> | ||
|
||
<pre class=prod><dfn><trigger-name></dfn> = <<dashed-ident>></pre> | ||
|
||
## The 'animation-trigger-event' property ## {#animation-trigger-event} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this be moved up to sit among the other |
||
|
||
The 'animation-trigger-event' property is used to specify the criteria | ||
for [=qualifying events=] that cause an [=event-based animation trigger=] | ||
Comment on lines
+993
to
+994
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this be the other way around? As in, the event source should declare the types that emit its name, and the event targets should register to the name alone? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you give an example of the syntax you have in mind? It's not clear to me how to express the following using your suggestion:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. First of all, this example is rather confusing to me. Did you intentionally used an example with two identical names? Are they supposed to collide? Or to be aggregated? So to simplify with 2 different names, I was thinking on something like:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think your proposed syntax is isomorphic to mine, but your syntax occupies more of the --dashed-ident namespace, because it refers to an (event type, event target) pair rather than just an event target; and because it seems to require uniqueness of --dashed-ident labels for triggers -- that's why I deliberately created an example with two identical names. The idea here is that there may be multiple event targets that all affect a single animation target. Here's a comparison of the two syntaxes:
-or-
Now suppose that we want either a click or a keypress to either of the event targets to trigger the animation:
-or-
Again, I think these syntaxes are isomorphic. My own preference to avoid --dashed-ident namespace pollution by allowing non-unique identifiers and pushing the event type specification into the animation target's style, but I don't have my heart set on it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, your idea for allowing multiple event targets to trip the same trigger (not animation) is quite interesting, but I can't think right now on anything that works that way, so it seems quite confusing. In most cases I can think of idents override each other, and are not aggregated, but I could be missing something. Regarding the syntax you used in the examples above, since |
||
to perform its effect on its associated [=animation=]. It consists of two parts: | ||
a <<trigger-event-type>> that is matched against the {{Event/type}} of a dispatched {{Event}}, | ||
and an <<trigger-name>> that is matched against the 'animation-trigger-name' property | ||
of the event's {{Event/target}}. If both criteria match for a given event | ||
the trigger will perform its effect on its associated [=animation=]. | ||
|
||
If the <<trigger-name>> is omitted from <<single-trigger-event>> declaration, | ||
{{Event/target}} is matched against the element | ||
having the 'animation-trigger-event' property itself. | ||
|
||
<pre class='propdef'> | ||
Name: animation-trigger-event | ||
Value: none | [ <<single-trigger-event>> ]# | ||
Initial: none | ||
Applies to: all elements | ||
Inherited: no | ||
Percentages: N/A | ||
Computed value: as specified | ||
Animation type: not animatable | ||
</pre> | ||
|
||
<pre class=prod><dfn><single-trigger-event></dfn> = event ( <<trigger-event-type>> <<trigger-name>>? )</pre> | ||
<pre class=prod><dfn><trigger-event-type></dfn> = <<custom-ident>></pre> | ||
|
||
## The 'animation-trigger' property ## {#animation-trigger} | ||
|
||
The 'animation-trigger' property is a [=shorthand property|shorthand=] | ||
that sets 'animation-trigger-behavior', 'animation-trigger-timeline', | ||
'animation-trigger-range-start', 'animation-trigger-range-end', | ||
'animation-trigger-event', 'animation-trigger-range-start', 'animation-trigger-range-end', | ||
'animation-trigger-exit-range-start', and 'animation-trigger-exit-range-end' | ||
together in a single declaration, | ||
specifying the [=animation trigger=] for an animation. | ||
together in a single declaration, specifying the [=animation trigger=] for an animation. | ||
|
||
<pre class='propdef'> | ||
Name: animation-trigger | ||
Value: <<single-animation-trigger>># | ||
Value: auto | none | <<single-animation-trigger>># | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So far we intentionally didn't have a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, probably if we do allow There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I misunderstood before how coordinated lists were being used; I will fix this. |
||
Initial: see individual properties | ||
Applies to: all elements | ||
Inherited: no | ||
|
@@ -984,7 +1038,9 @@ Animation Type: not animatable | |
</pre> | ||
|
||
<pre class=prod> | ||
<dfn><single-animation-trigger></dfn> = <<single-animation-trigger-behavior>> || [ none | auto | [ [ <<dashed-ident>> | <<scroll()>> | <<view()>> ] [ normal | <<length-percentage>> | <<timeline-range-name>> <<length-percentage>>? ]{0,4} ] ] | ||
<dfn><single-animation-trigger></dfn> = [ <<single-animation-trigger-behavior>> | [ <<single-trigger-event>> | <<single-timeline-trigger>> ] ] <<single-animation-trigger-behavior>>? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure I follow the logic here. Perhaps you meant to allow There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also me not understanding coordinated lists; will fix. |
||
|
||
<dfn><single-timeline-trigger></dfn> = [ <<dashed-ident>> | <<scroll()>> | <<view()>> ] [ normal | <<length-percentage>> | <<timeline-range-name>> <<length-percentage>>? ]{0,4} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You changed the syntax of timeline here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also coordinated lists; will fix. |
||
</pre> | ||
|
||
# Animation Events # {#events} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I don't think it does?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The '#' in the syntax description from line 734 means it accepts a comma-separated list of behaviors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I think that has to do with the fact that multiple animations can be specified in a comma-separated list. Each animation will then be mapped 1:1 with a comma-separated list of triggers. Each trigger still only gets one behavior. Though idk if this has been incorrectly represented in the spec text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, what @DavMila said is correct. I think this is called a coordinated list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it; I will update the PR...