Skip to content

[css-forms-1] Add 24px sizing rule for checkbox and radio inputs #12489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lukewarlow
Copy link
Member

See #12430

@lukewarlow lukewarlow requested a review from nt1m July 16, 2025 22:23
@lukewarlow lukewarlow marked this pull request as ready for review July 16, 2025 22:24
Comment on lines +846 to +853
/* These size rules ensure accessibility by following WCAG rules:
* https://www.w3.org/WAI/WCAG22/Understanding/target-size-minimum.html */
block-size: max(1em, 24px);
inline-size: max(1em, 24px);

/* This font-size rule ensures the checkmark fills the containing box. */
font-size: max(1em, 24px);

Copy link
Member

@nt1m nt1m Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

font-size would control both block-size and inline-size technically, so this would have the same effect.

    block-size: 1em;
    inline-size: 1em;
    font-size: max(1em, 24px);

cc @fantasai to look at this

@nt1m nt1m requested a review from fantasai July 16, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants