Skip to content

Issue #486 ValidationReport UML #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: gh-pages
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions shacl12-core/images/Makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
all: ValidationReport-UML.svg

%.svg: %.puml
plantuml -Tsvg $^
23 changes: 23 additions & 0 deletions shacl12-core/images/ValidationReport-UML.puml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
@startuml
hide circles
hide empty members
skinparam pathHoverColor red ' on cover, highlight blue links as red

class "<color:blue><u>sh:ValidationReport" as ValidationReport [[#results-validation-report]] {
[[#conforms sh:conforms]] : xsd:boolean
[[#shapesGraphWellFormed sh:shapesGraphWellFormed]] : xsd:boolean
}

class "<color:blue><u>sh:ValidationResult" as ValidationResult [[#results-validation-result]] {
[[#results-focus-node sh:focusNode]] : any
[[#results-path sh:resultPath]] : [[#property-paths SHACL prop path]]
[[#results-value sh:value]] : any
[[#results-source-shape sh:sourceShape]] : [[#shapes sh:Shape]]
[[#results-source-constraint-component sh:sourceConstraintComponent]] : [[#dfn-constraint-component sh:ConstraintComponent]]
[[#results-message sh:resultMessage]] : xsd:string or rdf:langString
[[#results-severity sh:resultSeverity]] : [[#severity sh:Severity]]
}

ValidationReport --> ValidationResult : [[#result sh:result]] *
ValidationResult -> ValidationResult : [[#results-detail sh:detail]] *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ValidationResult -> ValidationResult : [[#results-detail sh:detail]] *
ValidationResult -> AbstractResult : [[#results-detail sh:detail]] *

I think sh:detail should point to sh:AbstractResult.
We could also add an entry for sh:AbstractResult, which is the superclass of sh:ValidationResult.

@enduml
1 change: 1 addition & 0 deletions shacl12-core/images/ValidationReport-UML.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
26 changes: 20 additions & 6 deletions shacl12-core/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -2920,8 +2920,9 @@ <h3>Validation Report</h3>
<p>
The <dfn data-lt="validation report|report">validation report</dfn> is the result of the <a>validation</a> process that reports the <a>conformance</a> and the set of all <dfn data-lt="validation result|result">validation results</dfn>.
The validation report is described with the SHACL <dfn>Validation Report Vocabulary</dfn> as defined in this section.
This vocabulary defines the RDF properties to represent structural information that may provide guidance on how to identify or fix violations in the data graph.
This vocabulary defines the RDF classes and properties to represent structural information that may provide guidance on how to identify or fix violations in the data graph:
</p>
<div id="ValidationReport-UML.svg></div>
<p><!-- ISSUE-181 -->
SHACL-compliant processors MUST be capable of returning a validation report with all required <a>validation results</a>
described in this specification.
Expand Down Expand Up @@ -7976,11 +7977,24 @@ <h2>Changes between SHACL 1.0 Core and SHACL 1.2 Core</h2>

<script type="text/javascript">

tooltip = "Targets are not the only way to initiate validation, SHACL also allows specific nodes to be validated against specific shapes.";
var t = document.getElementsByClassName("target-can-be-skipped");
for (var i = 0; i < t.length; i++) {
t[i].title = tooltip;
}
// tooltip = "Targets are not the only way to initiate validation, SHACL also allows specific nodes to be validated against specific shapes.";
// var t = document.getElementsByClassName("target-can-be-skipped");
// for (var i = 0; i < t.length; i++) {
// t[i].title = tooltip;
// }

// Load and inline SVG diagrams
// TODO: add <svg desc> for accessibility
function svgInline(svg) {
fetch('images/'+svg)
.then(response => response.text())
.then(svgText => {
const container = document.getElementById(svg);
container.innerHTML = svgText;
})};

// svgInline('SHACL-UML.svg');
svgInline('ValidationReport-UML.svg');

</script>

Expand Down
4 changes: 2 additions & 2 deletions shacl12-vocabularies/shacl-shacl.ttl
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ shsh:
shsh:ListShape
a sh:NodeShape ;
rdfs:label "List shape"@en ;
rdfs:comment "A shape describing well-formed RDF lists. Currently does not check for non-recursion. This could be expressed using SHACL-SPARQL."@en ;
rdfs:comment "A shape describing well-formed RDF lists. Currently does not check for non-recursion (this could be expressed using SHACL-SPARQL)."@en ;
rdfs:seeAlso <https://www.w3.org/TR/shacl/#syntax-rule-SHACL-list> ;
sh:property [
sh:path [ sh:zeroOrMorePath rdf:rest ] ;
rdfs:comment "Each list member (including this node) must be have the shape shsh:ListNodeShape."@en ;
rdfs:comment "Each list member (including this node) must have the shape shsh:ListNodeShape."@en ;
sh:hasValue rdf:nil ;
sh:node shsh:ListNodeShape ;
] .
Expand Down