Skip to content

Adjusted text color for the 'support' class in dark mode#2772

Merged
iherman merged 1 commit intomainfrom
support-class-in-dark-mode
Aug 18, 2025
Merged

Adjusted text color for the 'support' class in dark mode#2772
iherman merged 1 commit intomainfrom
support-class-in-dark-mode

Conversation

@iherman
Copy link
Member

@iherman iherman commented Aug 6, 2025

The color was a light gray on yellowish background, which was unreadable. I set the text color to dark gray and left the background as is.

Best seen on its effect on RS:

See:

@iherman iherman requested a review from mattgarrish as a code owner August 6, 2025 08:08
@github-project-automation github-project-automation bot moved this to In review in PM/EPUB issues Aug 6, 2025
@iherman iherman self-assigned this Aug 6, 2025
@iherman iherman added the Type-Editorial The issue does not affect conformance label Aug 6, 2025
@mattgarrish
Copy link
Member

mattgarrish commented Aug 14, 2025

It's kind of shockingly bright with everything else black.

What about using var(--note-bg) and var(--note-text), instead, and extend a 1px yellow border around the top, right, and bottom to make it more like the note boxes in dark mode?

@iherman
Copy link
Member Author

iherman commented Aug 18, 2025

This is a purely stylistic change, does not change the text. Merging it, to get it out of the way, we can always refine it later if we wish. At this moment, it will make things more readable.

@iherman iherman merged commit 31c82d3 into main Aug 18, 2025
13 checks passed
@iherman iherman deleted the support-class-in-dark-mode branch August 18, 2025 12:56
@github-project-automation github-project-automation bot moved this from In review to Done in PM/EPUB issues Aug 18, 2025
@iherman
Copy link
Member Author

iherman commented Aug 18, 2025

It's kind of shockingly bright with everything else black.

What about using var(--note-bg) and var(--note-text), instead, and extend a 1px yellow border around the top, right, and bottom to make it more like the note boxes in dark mode?

Oops, sorry, my bad, I completely missed this remark. I should not have merged this.

There is no "unmerge", but I will do a separate one with your proposals. Actually, there may be a need to completely rework the common.css file using variables (with a special variable setting for dark mode)...

@iherman iherman removed this from PM/EPUB issues Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type-Editorial The issue does not affect conformance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments