Skip to content

Adds test to prevent repeated variables in VALUES #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adds test to prevent repeated variables in VALUES #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b1f927
Adds test to prevent repeated variables in VALUES
Tpt Oct 1, 2025
2ad0f29
Automated manifest generation
Tpt Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion rdf/rdf12/rdf-semantics/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,17 @@ <h2>
<dt>type</dt>
<dd>mf:PositiveEntailmentTest</dd>
<dt>approval</dt>
<dd property='mf:approval' resource=''></dd>
<dd property='mf:approval' resource=''>none</dd>
<dt>entailmentRegime</dt>
<dd property='mf:entailmentRegime'></dd>
<dt>recognizedDatatypes</dt>
<dd>
<code inlist='true' property='mf:recognizedDatatypes' resource='xsd:integer'>xsd:integer</code>
</dd>
<dt>unrecognizedDatatypes</dt>
<dd>
<code property='mf:unrecognizedDatatypes' resource='rdf:nil'>none</code>
</dd>
<dt>action</dt>
<dd>
<a href='canonical-literal-control.ttl' property='mf:action'>canonical-literal-control.ttl</a>
Expand Down
3 changes: 3 additions & 0 deletions sparql/sparql12/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,9 @@ <h2>
<li>
<a href='syntax-triple-terms-positive/index.html' inlist='true' property='mf:include'>syntax-triple-terms-positive/</a>
</li>
<li>
<a href='syntax/index.html' inlist='true' property='mf:include'>syntax/</a>
</li>
</ul>
</div>
<footer>
Expand Down
1 change: 1 addition & 0 deletions sparql/sparql12/manifest.ttl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,5 @@ trs:manifest rdf:type mf:Manifest ;
<expression/manifest.ttl>
<lang-basedir/manifest.ttl>
<rdf11/manifest.ttl>
<syntax/manifest.ttl>
) .
1 change: 1 addition & 0 deletions sparql/sparql12/syntax/duplicated-values-variable.rq
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
SELECT * WHERE { VALUES (?a ?a) { (1 1) } }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right place.

  1. It isn't an expression.
  2. All syntax tests go in a directory name of the form syntax-*, separate from eval tests.

Suggestion: start a new directory: sparql/sparql12/syntax for both positive syntax-*.rq tests and syntax-bad-*.rq for syntax tests that do not warrant their own directory.

Discussion: should this be in sparql11?

Copy link
Contributor Author

@Tpt Tpt Oct 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, a syntax folder would be great. Will do so.

Discussion: should this be in sparql11?

imho it's undefined behavior in SPARQL 1.1 and is only defined in SPARQL 1.2 so an implementation doing something else would be still compliant with SPARQL 1.1. This is why I put this test in SPARQL 1.2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why I put this test in SPARQL 1.2.

OK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved into a new syntax dir

106 changes: 106 additions & 0 deletions sparql/sparql12/syntax/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
<!DOCTYPE html>
<html lang='en' prefix='dawgt: http://www.w3.org/2001/sw/DataAccess/tests/test-dawg# mf: http://www.w3.org/2001/sw/DataAccess/tests/test-manifest# mfx: http://jena.hpl.hp.com/2005/05/test-manifest-extra# qt: http://www.w3.org/2001/sw/DataAccess/tests/test-query# sd: http://www.w3.org/ns/sparql-service-description# ut: http://www.w3.org/2009/sparql/tests/test-update#'>
<head>
<meta content='text/html;charset=utf-8' http-equiv='Content-Type'>
<meta content='width=device-width, initial-scale=1.0' name='viewport'>
<link href='https://www.w3.org/StyleSheets/TR/base' rel='stylesheet' type='text/css'>
<style>
body {background-image: none;}
dl.editor>dd {
margin: 0 0 0 40px;
}
dl.test-detail {
padding: 0.5em;
}
dl.test-detail>dt {
float: left;
clear: left;
text-align: right;
font-weight: bold;
color: green;
}
dl.test-detail>dt:after {content: ": "}
dl.test-detail>dd {
margin: 0 0 0 110px;
padding: 0 0 0.5em 0;
}
dl.test-description>dt {margin-top: 2em;}
dd {margin-left: 0;}
dd code {display: inline;}
footer {text-align: center;}
</style>
<title>
Syntax
</title>
<style>
em.rfc2119 {
text-transform: lowercase;
font-variant: small-caps;
font-style: normal;
color: #900;
}
a.testlink {
color: inherit;
text-decoration: none;
}
a.testlink:hover {
text-decoration: underline;
}
.warning {color: orange;}
.error {color: red;}
</style>
</head>
<body resource='manifest#manifest' typeof='mf:Manifest'>
<p>
<a href='http://www.w3.org/'>
<img alt='W3C' height='48' src='http://www.w3.org/Icons/w3c_home' width='72'>
</a>
</p>
<h1 property='rdfs:label'>Syntax</h1>
<p><a href="http://www.w3.org/Consortium/Legal/ipr-notice#Copyright">Copyright</a> © 2010 <a href="http://www.w3.org/"><acronym title="World Wide Web Consortium">W3C</acronym></a><sup>®</sup> (<a href="http://www.csail.mit.edu/"><acronym title="Massachusetts Institute of Technology">MIT</acronym></a>, <a href="http://www.ercim.org/"><acronym title="European Research Consortium for Informatics and Mathematics">ERCIM</acronym></a>, <a href="http://www.keio.ac.jp/">Keio</a>), All Rights Reserved. W3C <a href="http://www.w3.org/Consortium/Legal/ipr-notice#Legal_Disclaimer">liability</a>, <a href="http://www.w3.org/Consortium/Legal/ipr-notice#W3C_Trademarks">trademark</a>, and <a href="http://www.w3.org/Consortium/Legal/copyright-documents">document use</a> rules apply.</p>
<hr title='Separator for header'>
<div>
<h2 id='abstract'>Abstract</h2>
<p property='rdfs:comment'>
</p>
<p>This page describes SPARQL 1.2 test suite of the W3C RDF &amp; SPARQL Working Group.</p>
<h3 id='contributing-tests'>Contributing Tests</h3>
<p>The test manifests and entries are built automatically from <a href="manifest.ttl">manifest.ttl</a> using a Rake task. Tests may be contributed via pull request to <a href="https://github.com/w3c/rdf-tests">https://github.com/w3c/rdf-tests</a> with suitable changes to the <a href="manifest.ttl">manifest.ttl</a> and referenced files.</p>
<h3 id='distribution'>Distribution</h3>
<p>Distributed under both the <a href="http://www.w3.org/Consortium/Legal/2008/04-testsuite-license">W3C Test Suite License</a> and the <a href="http://www.w3.org/Consortium/Legal/2008/03-bsd-license">W3C 3-clause BSD License</a>. To contribute to a W3C Test Suite, see the <a href="http://www.w3.org/2004/10/27-testcases">policies and contribution forms</a>.</p>
<h3 id='disclaimer'>Disclaimer</h3>
<p>UNDER BOTH MUTUALLY EXCLUSIVE LICENSES, THIS DOCUMENT AND ALL DOCUMENTS, TESTS AND SOFTWARE THAT LINK THIS STATEMENT ARE PROVIDED "AS IS," AND COPYRIGHT HOLDERS MAKE NO REPRESENTATIONS OR WARRANTIES, EXPRESS OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE, NON-INFRINGEMENT, OR TITLE; THAT THE CONTENTS OF THE DOCUMENT ARE SUITABLE FOR ANY PURPOSE; NOR THAT THE IMPLEMENTATION OF SUCH CONTENTS WILL NOT INFRINGE ANY THIRD PARTY PATENTS, COPYRIGHTS, TRADEMARKS OR OTHER RIGHTS.
COPYRIGHT HOLDERS WILL NOT BE LIABLE FOR ANY DIRECT, INDIRECT, SPECIAL OR CONSEQUENTIAL DAMAGES ARISING OUT OF ANY USE OF THE DOCUMENT OR THE PERFORMANCE OR IMPLEMENTATION OF THE CONTENTS THEREOF.</p>
</div>
<div>
<h2>
Test Descriptions
</h2>
<dl class='test-description'>
<dt id='duplicated-values-variable'>
<a class='testlink' href='#duplicated-values-variable'>
duplicated-values-variable:
</a>
<span about='manifest#duplicated-values-variable' property='mf:name'>Duplicated variable in a VALUES clause</span>
</dt>
<dd inlist='true' property='mf:entry' resource='manifest#duplicated-values-variable' typeof='mf:NegativeSyntaxTest'>
<div property='rdfs:comment'>
</div>
<dl class='test-detail'>
<dt>type</dt>
<dd>mf:NegativeSyntaxTest</dd>
<dt>approval</dt>
<dd property='mf:approval' resource=''></dd>
<dt>action</dt>
<dd>
<a href='duplicated-values-variable.rq' property='mf:action'>duplicated-values-variable.rq</a>
</dd>
</dl>
</dd>
</dl>
</div>
<footer>
<p><a href="http://www.w3.org/Consortium/Legal/ipr-notice#Copyright">Copyright ©</a> 2015 <a href="http://www.w3.org/">W3C</a>® (<a href="http://www.csail.mit.edu/">MIT</a>, <a href="http://www.ercim.org/">ERCIM</a>, <a href="http://www.keio.ac.jp/">Keio</a>, <a href="http://ev.buaa.edu.cn/">Beihang</a>). W3C® <a href="http://www.w3.org/Consortium/Legal/ipr-notice#Legal_Disclaimer">liability</a>, <a href="http://www.w3.org/Consortium/Legal/ipr-notice#W3C_Trademarks">trademark</a> and <a href="http://www.w3.org/Consortium/Legal/copyright-documents">document use</a> rules apply.</p>
</footer>
</body>
</html>
17 changes: 17 additions & 0 deletions sparql/sparql12/syntax/manifest.ttl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
@prefix : <https://w3c.github.io/rdf-tests/sparql/sparql12/syntax/manifest#> .
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
@prefix mf: <http://www.w3.org/2001/sw/DataAccess/tests/test-manifest#> .
@prefix qt: <http://www.w3.org/2001/sw/DataAccess/tests/test-query#> .
@prefix dawgt: <http://www.w3.org/2001/sw/DataAccess/tests/test-dawg#> .

:manifest rdf:type mf:Manifest ;
rdfs:label "Syntax" ;
mf:entries
(
:duplicated-values-variable
) .

:duplicated-values-variable rdf:type mf:NegativeSyntaxTest ;
mf:name "Duplicated variable in a VALUES clause" ;
mf:action <duplicated-values-variable.rq> .