Skip to content

Conform 'current time' definition to the current hr-time spec #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Conform 'current time' definition to the current hr-time spec #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,13 @@
wgPatentURI: "https://www.w3.org/2004/01/pp-impl/45211/status",
wgPatentPolicy: "PP2017",
xref: ["html", "hr-time-2", "performance-timeline-2"],
localBiblio: {
"HR-TIME-ED": {
title: "High Resolution Time Editor's Draft",
status: "ED",
href: "https://w3c.github.io/hr-time/",
},
}
};
</script>
</head>
Expand Down Expand Up @@ -216,9 +223,9 @@ <h2>Terminology</h2>
[[HR-TIME-2]]. For example, the <a data-cite=
"NAVIGATION-TIMING-2#dom-PerformanceNavigationTiming-startTime">start
of navigation of the document</a> occurs at time 0.</p>
<p>The term <dfn>current time</dfn> refers to the number of
milliseconds since the start of navigation of the document until
the current moment in time.</p>
<p>The term <dfn>current time</dfn> refers to the result of running
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd be better off eliminating this dfn, and call the algorithm directly with the current global object from the few places in the processing model that are calling it.

The reason for that is that we need to call it with a specific global object, and this dfn doesn't give us that. Does that make sense?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good and also seems more robust since I have observed that the term current time is mostly used in algorithmic steps in this spec.

So would replacing occurences like:
record the <a>current time</a> in <a>startTime</a>
with
record the result of <a data-cite="HR-TIME-ED#dfn-current-high-resolution-time">current high resolution time</a> where |current global| is {{Window}} in <a>startTime</a>
fit the case ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{{Window}} is a reference to the Window object, but not to a specific window.
You probably want to reference the current global object

<a data-cite="HR-TIME-ED#dfn-current-high-resolution-time">current high
resolution time</a> where |current global| is the {{Window}} object.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can add an inline issue (<p class=issue> IIRC) to align this to the published spec, once we've actually published it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not needed as this will be on L3, right ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed!

<p class='note'>This definition of time is based on the High
Resolution Time specification [[HR-TIME-2]] and is different from
the definition of time used in the Navigation Timing specification
Expand Down