Add missing parameter name for algorithm #585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It currently lists all parameters explicitly, except for `input`. While implementing this algorithm in Servo, I was confused what the value of `input` is supposed to be. Then I saw that it is probably the third argument, so let's make that explicit.
Contributor
Author
|
I have linked my GitHub acccount to a W3C account |
Contributor
Author
|
@fred-wang do you mind restarting this build? Seems like a tiny fix |
Collaborator
|
@TimvdLippe mmh, I don't know how I can do that (maybe @lukewarlow knows?). Shouldn't a forced push do that automatically? |
Contributor
Author
|
I made this change via the GitHub UI and don't have a local copy available that I can run git commands on :/ I could recreate the PR? |
Collaborator
|
Sorry I don't think I can relaunch the ipr check |
Member
|
I'm going to go ahead and mark this as non substantative because that's what it is |
|
lukewarlow marked as non substantive for IPR from ash-nazg. |
github-actions bot
added a commit
to lukewarlow/trusted-types
that referenced
this pull request
Jul 3, 2025
SHA: fbd1144 Reason: push, by lukewarlow Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Jul 3, 2025
SHA: fbd1144 Reason: push, by lukewarlow Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
Author
|
Cool thanks for figuring it out! |
github-actions bot
added a commit
to foolip/trusted-types
that referenced
this pull request
Sep 5, 2025
SHA: fbd1144 Reason: push, by foolip Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It currently lists all parameters explicitly, except for
input. While implementing this algorithm in Servo, I was confused what the value ofinputis supposed to be. Then I saw that it is probably the third argument, so let's make that explicit.Preview | Diff