Remove strict name validation on assert.rejects statements #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PatStLouis <[email protected]>
BigBlueHat
approved these changes
Oct 17, 2024
Member
BigBlueHat
left a comment
BigBlueHat
left a comment
There was a problem hiding this comment.
Seems OK to me. That was likely my fault as I was hoping to make it clear what types of errors we were expecting...but given the way APIs jump around, I think you're right and that specificity likely isn't important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had occurrences where my server was returning a different type of error than what the test suite was expecting (ex: returning an
HTTPExceptioninstead of anHTTPError) and marked the test as failed even if my server behaved correctly. I wonder if checking for a specific type of error is too strict of a validation here?