Skip to content

Conversation

BigBlueHat
Copy link
Member

@BigBlueHat BigBlueHat commented Aug 26, 2025

This is based on #77 by @ashushukla0412, but takes a more minimal approach.

@ashushukla0412 I'd be curious to know if these changes are sufficient for what you were seeing.

@BigBlueHat BigBlueHat requested a review from davidlehn August 26, 2025 21:27
@BigBlueHat BigBlueHat changed the title use document loader fix terms Use document loader and fix missing terms. Aug 26, 2025
@ashushukla0412
Copy link

Yup this is working. Adding those terms in contexts was what was needed.

PS. If refactoring is on the cards, I'd suggest cleaning up contexts.js. Maybe structure it in data-integrity-test-suite style

@BigBlueHat
Copy link
Member Author

PS. If refactoring is on the cards, I'd suggest cleaning up contexts.js. Maybe structure it in data-integrity-test-suite style

@ashushukla0412 is there something in that file you like specifically? It looks like the original author felt that one also needed some work--judging by the "FIXME"s: https://github.com/w3c-ccg/data-integrity-test-suite-assertion/blob/main/vc-generator/contexts.js#L44-L52

That said, I agree this could all be made clearer... Happy to hear your thoughts on what you'd like to see!

@BigBlueHat BigBlueHat merged commit 6c8aabb into main Aug 27, 2025
2 checks passed
@BigBlueHat BigBlueHat deleted the use-document-loader-fix-terms branch August 27, 2025 14:31
@ashushukla0412
Copy link

@BigBlueHat Thanks for considering my suggestion. I think both named credential contexts and DID Contexts can be initialized in same way. Also, and this is very minor, what about renaming vc2Context to v2Context?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants