Skip to content

Add Conformance & Data Model Suites (1) #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 21 commits into from
Closed

Add Conformance & Data Model Suites (1) #94

wants to merge 21 commits into from

Conversation

@aljones15
Copy link
Contributor

@aljones15 aljones15 commented Nov 6, 2024 •
edited
Loading

  1. Adds two normative statements from Conformance section
  2. Adds 3 minimal negative tests for those statements
  3. Reuses code from the data-integrity-test-suite-assertion
  4. Adds a new suites dir which contains functions that create parametertized suites
  5. Contains fixes from Add data model suite #95

This PR is intended to be the final stop for all of the ecdsa related rewrites in the current sprint.

@aljones15 aljones15 self-assigned this Nov 6, 2024
aljones15 and others added 13 commits November 12, 2024 09:47
@aljones15
Add initial data model suite intended for issuers.
0ebad02
@aljones15
Add assertBefore & endpoint check.
40b5bd5
@aljones15
Fill in first VM test & get proofs.
a277997
@aljones15
Add further assertions on proofs to data model suite.
d990225
@aljones15
Add initial data-model test.
a308742
@aljones15
Remove proofValue test from data model & update links.
c89ef2a
@aljones15
Comment out jcs & correct naming in before statement.
f4f6507
@aljones15
Use didResolver to assert on publicKeyMultibase.
93173ef
@aljones15 @TallTed
Update tests/suites/data-model.js add period to end of sentence.
4100168 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@aljones15 @TallTed
Update tests/suites/data-model.js add period to bs58 reason.
5cef3a4 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@aljones15 @TallTed
Update tests/suites/data-model.js add missing period to end of bs58 r…
8eb7748 
…eason.

Co-authored-by: Ted Thibodeau Jr <[email protected]>
@aljones15
Update tests/suites/data-model.js Remove trailing A from end of sente…
dc39f44 
…nce.
@aljones15
Handle implemented & multi-key-types.
0da7625
@aljones15 aljones15 changed the title Add conformance suite Add Conformance & Data Model Suites Nov 12, 2024
@aljones15 aljones15 changed the title Add Conformance & Data Model Suites Add Conformance & Data Model Suites (1) Nov 15, 2024
@BigBlueHat BigBlueHat closed this Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BigBlueHat BigBlueHat BigBlueHat approved these changes

@PatStLouis PatStLouis PatStLouis approved these changes

@tminard tminard Awaiting requested review from tminard

Assignees

@aljones15 aljones15

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aljones15 @BigBlueHat @PatStLouis