Skip to content

Conversation

ostafinskim
Copy link
Member

New navigation components and landing page templates with the updated logo.

@simonrjones
Copy link
Member

Published to the staging site, see Basecamp message: https://3.basecamp.com/3091560/buckets/32734213/messages/8134231991

This work is being reviewed by W3C, please don't merge it in at present.

@simonrjones simonrjones marked this pull request as draft December 17, 2024 10:32
@vivienlacourba
Copy link
Member

@simonrjones, @ostafinskim, FYI @jean-gui is starting to review this work.

For the changes related to deployer fixes as those have already been merged in the main branch, they should probably not be part of this MR anymore (maybe it simply needs to be rebased against main).

@jean-gui jean-gui force-pushed the feature/update-logo branch from b8d1284 to 65d7915 Compare January 10, 2025 11:00
@jean-gui
Copy link
Contributor

Hi @ostafinskim @simonrjones,

I have pushed a few changes to this PR:

We don't know yet which main logo to use. Once we know we can update all the templates accordingly and remove the two test pages from the design system.

The new style can be seen in action at https://www-dev.w3.org/.

I noticed that the main logo doesn't have a fixed size. It is smaller when logged in. It then seems to depend on the width of the "My account" block. This does not happen with the older version because the CSS specified a width and height, while the new one only has a max-width.

@ostafinskim
Copy link
Member Author

Hi @jean-gui,

Thank you for the recent changes and all the detailed updates!

I have edited the logo styles again and deployed the changes to the staging site for review.

Many thanks,

Copy link
Member

@sean-dunwoody sean-dunwoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logo currently has no spacing between it and the main navigation. This doesn't look right, and is more noticeable when the focus state is active on the first menu item:

Screenshot 2025-01-20 at 12 32 34
Screenshot 2025-01-20 at 12 32 29

This could be fixed by applying some right margin on the logo, or using the gap CSS property on the header flexbox container.

Beyond that the other changes look OK to me.

@ostafinskim ostafinskim marked this pull request as ready for review February 27, 2025 16:39
Copy link
Member

@sean-dunwoody sean-dunwoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor amends. Thanks for your work on this @ostafinskim 👍

@jean-gui jean-gui force-pushed the feature/update-logo branch from 721c347 to 16ae5a0 Compare June 26, 2025 12:23
Copy link
Contributor

@jean-gui jean-gui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly looks good to me. This code is deployed to www-dev.

@ostafinskim Can you please merge the old and new landing page templates? We don't need both.

@jean-gui
Copy link
Contributor

This mostly looks good to me. This code is deployed to www-dev.

@ostafinskim Can you please merge the old and new landing page templates? We don't need both.

ping @ostafinskim @sean-dunwoody @simonrjones

@gosko
Copy link
Member

gosko commented Sep 22, 2025

This is not very important, but the header spacing on www-dev looks a bit strange when viewed on a mobile device: the user profile icon is almost centered, but not quite. I don't think it's intended to be centered but it would be better if it were actually centered or closer to the menu icon as on the current site.

screenshot, mobile view of www-dev screenshot, mobile view of current site

@NicolaSaunders
Copy link
Contributor

The point made by @gosko is worth considering. At a 320px viewport width, the control for toggling the mobile navigation is forced to wrap onto a new line when visually there plenty of space for this not to happen (screenshot included to illustrate this).

Screenshot of the homepage at an emulated viewport width of 320px

Using the Flexbox gap property for controlling horizontal spacing between items has introduced these issues. It would be better to remove that and apply margin-inline-end / margin-inline-start onto the necessary elements to bring this closer to the current live implementation.

@jean-gui jean-gui merged commit 35bb823 into main Oct 1, 2025
1 check passed
@jean-gui jean-gui deleted the feature/update-logo branch October 1, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants