-
Notifications
You must be signed in to change notification settings - Fork 13
For publication / deploy on Wednesday July 16, 2025 #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…better reports on errors (#361) * Fix #219 * Update 'deploy.yml' to use 'w3cgruntbot' as committer * Update 'pr-create.yml' to force a rebase to happen with main in the case generated branch doesn't have relevant changes; additional error handling coverage with 'create-pr' script * For consistency, rename 'create-pr' script to 'pr-create' * Remove unnecessary delete branch action
…older to `pr-create.yml` (#373) * Add case to specially handle conflicts in submodule folder
…`pr-create.yml` (#375)
* Create .tracked-html-assets.json to make it easier to account for html assets which don't match with the expected html assets' naming structure
Remove unused files & update data submodule
Netlify has removed the option for clearing the cache on each build. This PR attempts to do that by removing the likely cache locations. This is needed because in very specific cases, when the changes coming from the `aria-practices` .gitmodule is force-pushed onto, it may not successfully rebuild unless the Netlify branch deploy is re-ran without the cache option.
Update netlify.toml to force a cache clearance
✅ Deploy Preview for aria-practices ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Drafting to resolve unexpected conflicts |
# Conflicts: # _external/aria-practices # _external/data # scripts/pre-build/library/.tracked-html-assets.json
@remibetin @shawna-slh having unexpected conflicts with Could #415 be reviewed so this can be moved forward? If not, could you advise on what's happened here and on what's best to do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from quick skim, nothing from me.
Syncing `main` with `publication`
@howard-e Thank you for your help fixing the conflicts. I have merged #415. I have also removed the CODEOWNERS file that is not needed anymore. This conflict probably appeared after I squash merged #394 in March. We had similar issues in other repositories and decided to stop squash merging in some repositories, including |
Thanks for checking it!
Okay noted, thanks for sharing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@howard-e I've added a couple comments. Please note that I have only skimmed the examples' CSS and JS assets.
Regarding the netlify.toml
file, I would appreciate more information about the issue you are facing.
Remove manual cache clear from `netlify.toml`
Thanks @remibetin! cc @a11ydoer this is ready for post-publication QA. Items I've checked as well:
Let me know if there's anything unexpected here. |
Hi @shawna-slh and @remibetin. We would like to deploy a new version of the APG. This was approved during this week's APG meeting by @mcking65 and @daniel-montalvo.
The update includes the following, sourced from w3c/aria-practices 2025-07-09 July 2025 APG Publication Milestone and pushed to w3c/aria-practices
main
branch:Add “expandable card/region” example to disclosure pattern (pull #3251)
By Adam Page on July 8, 2025
Resolves issue #3215 by adding a new example page under the disclosure pattern that illustrates cards that can be expanded and collapsed.
Co-authored-by: Howard Edwards
Co-authored-by: Matt King
View commit 8267510
Accordion Pattern: Remove extraneous colon character from heading (pull #3302)
By Matt King on July 8, 2025
Resolves issue #3300 by removing the trailing colon (:) character at the end of the heading for roles, states, and properties.
View commit 02b8edd
Example Disclosure for FAQ: Replace description list with unordered list (pull #3272)
By Jon Gunderson on June 9, 2025
Fixes issue #3269 by making the following changes:
View commit a8abeff
Landmark Regions Practice: Update search landmark guidance to include new HTML search element (pull #3249)
By Matt King on June 9, 2025
Fixes issue #2652.
The HTML spec now supports the
<search>
element. It maps to an implicitrole=search
.Changes:
Co-authored-by: Rami Yushuvaev
Co-authored-by: curtbellew
Co-authored-by: Jon Gunderson
Co-authored-by: Howard Edwards
View commit 9226c5e
Vertical Temperature Slider Example: Eliminate redundant AX tree rendering of value (pull #3258)
By Jon Gunderson on June 3, 2025
Fix issue #3257
Eliminate redundant announcement of the slider value by screen readers.
This commit moves the text node that visually displays the value above the slider.
It was previously outside the element with role slider.
It is now a child of the slider, making the text presentational.
View commit 6a933a9
Editable Combobox With Both List and Inline Autocomplete Example: Editorial correction to accessibility features documentation (pull #3252)
By Benjamin Gray on April 29, 2025
Changes "its border changes from two pixels to two" to "its border changes from two pixels to zero"
View commit 11ab69e