Skip to content

Change markers: add New visual style and remove unnecessary "text semantics" #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Change markers: add New visual style and remove unnecessary "text semantics" #1481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5975dc
Tweak `.change` styling
patrickhlauke Oct 17, 2020
7885c12
Remove square brackets around change markers
patrickhlauke Oct 17, 2020
05558a6
Darken background for > 7:1 contrast
patrickhlauke May 8, 2024
5981470
Merge branch 'main' into patrickhlauke-css-change-tweak
patrickhlauke Oct 30, 2024
b92fd14
Tweak padding subtly
patrickhlauke Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion guidelines/guidelines.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,13 @@
}

.change {
display:inline;
display: inline;
color: #fff;
background: #B50000;
border-radius: 0.25em;
padding: 0.25em 0.4em;
margin: 0 0.25em 0 0;
font-weight: bold;
}

.new {
Expand Down
5 changes: 0 additions & 5 deletions script/wcag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,6 @@ function linkUnderstanding() {
}

function addTextSemantics() {
// put brackets around the change marker
document.querySelectorAll('p.change').forEach(function(node){
var change = node.textContent;
node.textContent = "[" + change + "]";
})
// put level before and parentheses around the conformance level marker
document.querySelectorAll('p.conformance-level').forEach(function(node){
var level = node.textContent;
Expand Down