-
Notifications
You must be signed in to change notification settings - Fork 317
Updated Reflow understanding doc #4055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 144 commits
Commits
Show all changes
149 commits
Select commit
Hold shift + click to select a range
1cb8c80
Updated Reflow understanding doc
scottaohara 8d0f1f9
Update reflow.html
scottaohara b1e767f
Update understanding/21/reflow.html
scottaohara 7504dd2
Update understanding/21/reflow.html
scottaohara 005e080
new graphics used in the examples
scottaohara 60c3d71
add img folder to all new img src
scottaohara 8c2236e
note for sticky/fixed content
scottaohara 54adc01
fix missing word in 'what to do'
scottaohara 627dbc5
add clarifying note to 320x256 section
scottaohara bf3d520
pull in missing content from the external doc
scottaohara 6d1d428
revise initial intent paragraphs
scottaohara 89cecfe
updates to reflow doc
scottaohara 5e1ee84
content updates
scottaohara cfb36fb
Merge branch 'main' into scottaohara-reflow-understanding-rewrite
scottaohara a6dd504
Merge branch 'main' into scottaohara-reflow-understanding-rewrite
scottaohara 2453865
updates per external feedback
scottaohara 633eaa2
finish addressing external feedback
scottaohara 473a63b
adjust example image widths
scottaohara 030256f
re-arrange and fix p markup
scottaohara 845c55a
rewording of reorganized content
scottaohara ca79e05
new example screenshot
scottaohara 6296a9e
simplify wording
scottaohara 9dcfcbd
addressing issue 887
scottaohara ac903e5
fix incomplete sentence and punctuation fixes
scottaohara a475898
Create g20x.html
scottaohara 67e1761
Update understanding/21/reflow.html
scottaohara bc1d2f5
off screen to off-screen
scottaohara 2fdad82
Update understanding/21/reflow.html
fstrr 3670020
Update techniques/general/g20x.html
scottaohara b89e94f
address some of the feedback
scottaohara 7597c58
updates to first intent paragraph
scottaohara 9fe9bae
add more content to new indentation technique
scottaohara 9db3dba
Update understanding/21/reflow.html
scottaohara 9034790
Update understanding/21/reflow.html
scottaohara 8ffffcf
remove in-page link / text that was broken
scottaohara acbbb3f
Update understanding/21/reflow.html
scottaohara 389a46e
more wording updates
scottaohara dd46e18
Update understanding/21/reflow.html
scottaohara d2f5623
Update understanding/21/reflow.html
scottaohara ef48bf4
Update reflow.html
scottaohara 295747f
Update understanding/21/reflow.html
scottaohara 9eea703
Update understanding/21/reflow.html
scottaohara 5f390a5
Move image to correct folder
patrickhlauke 5e478ab
Subtly anonymise NPR examples, fix typos
patrickhlauke bf3507f
Tweak carousel images
patrickhlauke 7db653d
Merge branch 'main' into scottaohara-reflow-understanding-rewrite
patrickhlauke 17da9a4
Revise paragraph on table + paragraph reflow expectations
scottaohara 5287894
Update understanding/21/reflow.html
scottaohara 62dd7eb
Update understanding/21/reflow.html
scottaohara e720c0a
Update understanding/21/reflow.html
scottaohara 37ff092
Update alt text for code-diff gif
scottaohara be502a6
Merge branch 'main' into scottaohara-reflow-understanding-rewrite
patrickhlauke 9716370
Update understanding/21/reflow.html
scottaohara 4067f0d
Update understanding/21/reflow.html
scottaohara bb187a5
Working example of a new horizontally scrollable panel for the update…
giacomo-petri ccf6efa
Technique of a new horizontally scrollable panel for the updated refl…
giacomo-petri 573a3dc
pull in suggestions
scottaohara 75cd4c4
Merge branch 'main' into scottaohara-reflow-understanding-rewrite
patrickhlauke 7bd05ba
intent revisions
scottaohara 292aad8
Merge branch 'main' into scottaohara-reflow-understanding-rewrite
scottaohara 22cf5e1
a few more intent updates
scottaohara d6b16ee
revert in brief text
scottaohara 161fd19
new sections added, and further rewording
scottaohara 0a12d36
Merge branch 'main' into scottaohara-reflow-understanding-rewrite
scottaohara d1e83a1
Add files via upload
scottaohara 1d98aa6
Rename g20x.html to g301.html
scottaohara b2c67a3
Rename g20x2.html to g302.html
scottaohara 2d7de42
significant restructuring of the understanding doc
scottaohara 41a7bfd
fix typo
scottaohara c4412a2
cut down initial note
scottaohara b5250f4
cutting down first note some more
scottaohara 4ffe380
Delete understanding/21/img/reflow-macbook-resolutions.jpg.jpg
scottaohara 94c36c4
simplify figcaption text
scottaohara b984ba5
revise more content
scottaohara ac01e6f
Fix image file extension for figure 16
scottaohara 77ff758
relocate content from note 1
scottaohara b762a5e
code snippet working examples
scottaohara b67b061
Update index.html
scottaohara 89fc3bf
revise 301 tech
scottaohara d4eb537
revise g301
scottaohara 9bcd667
add working example for new 301 tech
scottaohara 795fd4c
Update understanding/21/reflow.html
scottaohara aeded95
Update understanding/21/reflow.html
scottaohara 6aeeb00
Update understanding/21/reflow.html
scottaohara b065239
revert merged suggestion
scottaohara b9707ec
Update understanding/21/reflow.html
scottaohara 54a691e
Update understanding/21/reflow.html
scottaohara 1028d0c
Update understanding/21/reflow.html
scottaohara 28b3c4c
Update understanding/21/reflow.html
scottaohara 7714c1d
Update understanding/21/reflow.html
scottaohara 3f1d823
Update understanding/21/reflow.html
scottaohara 0c181ef
Update understanding/21/reflow.html
scottaohara 333b9b5
Update understanding/21/reflow.html
scottaohara a0c7e38
Update understanding/21/reflow.html
scottaohara de88e1c
Update understanding/21/reflow.html
scottaohara d3f4342
Update understanding/21/reflow.html
scottaohara 739f907
Update understanding/21/reflow.html
scottaohara d83480a
Update understanding/21/reflow.html
scottaohara e729d5f
Update understanding/21/reflow.html
scottaohara 0d448bd
Update understanding/21/reflow.html
scottaohara 08503e5
Update understanding/21/reflow.html
scottaohara 76bc862
Update understanding/21/reflow.html
scottaohara 24e4e7b
Update understanding/21/reflow.html
scottaohara 92cc454
Update understanding/21/reflow.html
scottaohara 6f68917
Update understanding/21/reflow.html
scottaohara 8d1a094
Update understanding/21/reflow.html
scottaohara b42e91e
Update understanding/21/reflow.html
scottaohara c32f5dd
Update understanding/21/reflow.html
scottaohara 9a80c83
revise intro paragraph for 'reflowing websites and apps'
scottaohara 89e32aa
adjust intro to 'content that can benefit from 2-d layout..." section
scottaohara 0e1dca5
remove swimlanes and adjust content accordingly
scottaohara ce25641
Create .gitignore
scottaohara 21d7ef1
add video files
scottaohara 8c53c64
Rename carousel-pass-fail.mp4 to carousel-fail.mp4
scottaohara 6a1a1a6
Add video elements and update carousel descriptions
scottaohara 6c24b78
Delete understanding/21/video/.gitignore
scottaohara 8e42728
Update image width from 550px to 320px
scottaohara 778f719
Add files via upload
scottaohara fe61c6d
Update video source paths and content exception text
scottaohara 44bcdd6
make videos smaller to take up less vertical space
scottaohara a21b5d4
address gundula's request
scottaohara c74a78b
pull in last of francis's suggestions
scottaohara 9a9a3ae
add example files
scottaohara 9457400
add new pass/fail example in the table/grid section
scottaohara cbac8a2
Merge branch 'main' into scottaohara-reflow-understanding-rewrite
scottaohara 5eae0b9
Merge branch 'main' into scottaohara-reflow-understanding-rewrite
patrickhlauke 1cb29a7
Comment out 'benefits' section in reflow.html
scottaohara 952e023
Added 2nd example for comparison
giacomo-petri 13f99ec
Add hyperlink and update content for clarity for program guide
scottaohara a9da106
Update nested list example descriptions and details
scottaohara 36140b0
Merge branch 'main' into scottaohara-reflow-understanding-rewrite
scottaohara de68058
Adding two small videos to intent section
mbgower c894bef
Adding first image pair
mbgower b23499a
photo editor mockup
scottaohara cabcfd2
Update content and image in reflow.html
scottaohara 7424d7f
Merge branch 'main' into scottaohara-reflow-understanding-rewrite
scottaohara 1db93ae
Update understanding/21/reflow.html
fstrr 7a05556
Update understanding/21/reflow.html
fstrr 3d7f57d
Update understanding/21/reflow.html
fstrr bd7a63a
Add link to "electronic program guide" and update text resize section.
scottaohara 829a647
Update working-examples/reflow-carousel-panel-horizontal-scroll/index…
fstrr 26c3803
Update working-examples/reflow-carousel-panel-horizontal-scroll/index…
fstrr d3de87c
Merge branch 'main' into scottaohara-reflow-understanding-rewrite
scottaohara 3d3a038
Rename new techniques sequentially after existing ones
kfranqueiro 874fe86
Update G224 code indentation to be consistent with other techniques
kfranqueiro c63577e
Revert "Update G224 code indentation to be consistent with other tech…
kfranqueiro 77799e5
removed console logs and fixed alt attributes
giacomo-petri 3c634b8
escape code elements in example markup
scottaohara cc708e7
Update working-examples/reflow-indenting/index.html
scottaohara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,189 @@ | ||
<!DOCTYPE html> | ||
<html lang="en" xml:lang="en" xmlns="http://www.w3.org/1999/xhtml"> | ||
<head> | ||
<title>Accounting for meaningful text indentation and Reflow</title> | ||
<link rel="stylesheet" href="../../css/sources.css" class="remove"/> | ||
</head> | ||
<body> | ||
<h1>Accounting for meaningful text indentation and Reflow</h1> | ||
<section class="meta"><p class="id">ID: G224</p><p class="technology">Technology: general</p><p class="type">Type: Technique</p></section> | ||
<section id="applicability"> | ||
<h2>When to Use</h2> | ||
<p>All technologies that support style switching</p> | ||
</section> | ||
|
||
<section id="description"> | ||
<h2>Description</h2> | ||
<p>There can be instances where indentation of text is considered important to the presentation and understandability of the text content. If the indentations were to be removed, then meaning or functionality could suffer. For instance, the nesting of unordered lists can be harder to notice if indentations are removed. Additionally, maintaining indentations can be important to help understand code patterns, if not even necessary for the code to function.</p> | ||
<p>Since maintaining indentation is important for these instances of text, two-dimensional scrolling of these distinct sections of content could be necessary. However, there are still styling modifications that could be made to help ensure the indentation was maintained, but as much text was made visible within the viewport as possible. Making such adjustments could limit, if not mitigate any two-dimensional scrolling from occurring, making the content easier for people to read.</p> | ||
</div> | ||
</section> | ||
|
||
<section id="examples"> | ||
<h2>Examples</h2> | ||
<section class="example"> | ||
<p>A website conveys information in a nested list format. The understandability of the list hierarchy is supported by the indentation of the list content. While it is important for the individual list item text to reflow, the list hierarchy would suffer if flattened so that all content would fit within a 320 CSS pixel wide viewport.</p> | ||
<p>The following example list contains additional nested lists to provide more context for each of the parent list item's text. To maintain the visual hierarchy, the indentation of each list level remains present, but modified once an author defined CSS breakpoint is met. Additional styles are set for different breakpoints to mitigate against the potential for content to extend beyond a 320px wide viewport, while accounting for visual spacing against the borders of the viewport, to attempt to make the content not feel cramped. At the smallest breakpoint, the content of list items receive a minimum width to mitigate against potentially "squished" content lists with many nested levels. At this breakpoint, each nested list level can be horizontally scrolled into view, and once a nested list is visible within the viewport, only vertical scrolling will be necessary to read the content of the nested list's items.</p> | ||
<pre> | ||
<div class="example"> | ||
<ul> | ||
<li> | ||
<p>Make a list using one of the HTML list elements, or even an ARIA <code>role=list</code> container.</p> | ||
<ul> | ||
<li> | ||
<p>There are three types of lists in HTML which can contain list items (<code>li</code> elements.</p> | ||
<ul> | ||
<li><p>the <code>ul</code> element</li> | ||
<li><p>the <code>ol</code> element</li> | ||
<li><p>the <code>menu</code> element</li> | ||
</ul> | ||
</li> | ||
<li> | ||
<p>Another type of list, description lists, exist as well - but they do not contain list items (<code>li</code> elements).</p> | ||
</li> | ||
... | ||
</ul> | ||
</li> | ||
<li> | ||
<p>Neither the start or end tags of any of the HTML list elements are omissible.</p> | ||
<ul> | ||
<li><p>The end tags of <code>li</code> elements can be omitted if the <code>li</code> element is immeditely followed by another <code>li</code> element or there is no more content in the parent list element.</p> | ||
</li> | ||
... | ||
</ul> | ||
</li> | ||
... | ||
</ul> | ||
</div> | ||
</pre> | ||
<pre> | ||
*, *::before, *::after { | ||
box-sizing: border-box; | ||
} | ||
body, html { | ||
font-family: arial; | ||
} | ||
@media screen and ( max-width: 640px ) { | ||
.example { | ||
overflow: auto; | ||
max-width: 640px; | ||
} | ||
ul { | ||
padding-inline-start: 1.25em; | ||
} | ||
li p { | ||
padding: .25em; | ||
margin: .5em 0 .5em -.25em; | ||
max-width: 300px; /* saftey net for max-width */ | ||
} | ||
} | ||
@media screen and ( max-width: 400px ) { | ||
ul { padding-inline-start: 1em; } | ||
li p { min-width: 300px } { | ||
min-width: 300px; | ||
} | ||
} | ||
</pre> | ||
<p>A working example of <a href="../../working-examples/reflow-nested-lists">a list where nested levels can be read within a 320px wide viewport</a>.</p> | ||
</section> | ||
|
||
<section class="example"> | ||
<p>A website providing code snippets needs to maintain line indentations, as the indentations are meaningful not only to the structure of the code, but in some languages - such as with Python, are requirements when defining blocks of code.</p> | ||
<p>As a user zooms in the web page, the CSS of the indentation can be adjusted to maintain this necessary structure, while also allowing more text to be visible on a single line.</p> | ||
|
||
<p>The following represents a Python code example. The indentation of each line of text is necessary to create a group of statements that are executed as a block.</p> | ||
<pre> | ||
def complex_function(x): | ||
if x > 0: | ||
for i in range(x): | ||
if i % 2 == 0: | ||
print(f"{i} is even") | ||
for a in range(i): | ||
if a % 5 == 0: | ||
print(f" {a} can be divided by 5") | ||
else: | ||
print(f" {a} cannot be divided by 5") | ||
else: | ||
print(f"{i} is odd") | ||
for a in range(i): | ||
if a % 2 == 0: | ||
print(f" {a} is even") | ||
else: | ||
print(f" {a} is odd") | ||
else: | ||
print("x is not a positive number") | ||
</pre> | ||
<p>The following code example demonstrates the use of indentation to convey the nesting of elements in an HTML document:</p> | ||
<pre> | ||
<html lang=en> | ||
<head>...</head> | ||
<body> | ||
<div> | ||
<!-- ... keep indenting as necessary --> | ||
</div> | ||
</body> | ||
</html> | ||
</pre> | ||
<p>The indentation of code blocks like these could be adjusted at different viewport sizies, via a CSS Media Query.</p> | ||
<pre> | ||
@media screen and ( min-width: 320px ) { | ||
pre { | ||
tab-size: 8px; | ||
} | ||
} | ||
|
||
@media screen and ( min-width: 640px ) { | ||
pre { | ||
tab-size: 16px; | ||
} | ||
} | ||
|
||
@media screen and ( min-width: 1280px ) { | ||
pre { | ||
tab-size: 32px; | ||
} | ||
} | ||
</pre> | ||
<p>A working example of <a href="../../working-examples/reflow-indenting.html">code snippets using CSS to modigy indentation width at different breakpoints</a>. | ||
</section> | ||
</section> | ||
|
||
<section id="tests"> | ||
<h2>Tests</h2> | ||
<section class="procedure"><h3>Procedure for list example</h3> | ||
<ol> | ||
<li>Display the web page in a user agent where the page can be zoomed, or the user agent can be resized.</li> | ||
<li>Zoom in or resize the browser window so that the viewport is equivallent to 320 CSS pixels wide.</li> | ||
<li>The list content fits within the width so that it is only necessary so scroll vertically to read the list.</li> | ||
<li>Or, each nested list can be horizontally scrolled into view. Only vertical scrolling is necessary to read the content of list items within each specific nested list level.</li> | ||
</ol> | ||
</section> | ||
<section class="results"><h3>Expected Results</h3> | ||
<ul> | ||
<li>Checks 3 or 4 are true.</li> | ||
</ul> | ||
</section> | ||
|
||
<section class="procedure"><h3>Procedure for code snippets</h3> | ||
<ol> | ||
<li>Display the web page in a user agent where the page can be zoomed, or the user agent can be resized.</li> | ||
<li>Zoom in or resize the browser window so that the viewport is equivallent to 320 CSS pixels wide.</li> | ||
<li>The code snippets fits within the width so that it is only necessary so scroll vertically to read each line of code.</li> | ||
<li>Or, for code where non-wrapping lines are not essential, the code wraps or a mechanism is provided to allow line wrapping.</li> | ||
<li>Or, the indentation and linebreaks are meaningful to the code language. | ||
</ol> | ||
</section> | ||
<section class="results"><h3>Expected Results</h3> | ||
<ul> | ||
<li>Checks #3, #4 or #5 are true.</li> | ||
</ul> | ||
</section> | ||
</section> | ||
<section id="related"> | ||
<h2>Related Techniques</h2> | ||
<ul> | ||
<li><a href="../css/C20">C20</a></li> | ||
</ul> | ||
</section> | ||
</body> | ||
</html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
<!DOCTYPE html> | ||
<html lang="en" xml:lang="en" xmlns="http://www.w3.org/1999/xhtml"> | ||
<head> | ||
<title>Section panels that scroll horizontally are designed to fit within a width of 320 CSS pixels on a vertically scrolling page</title> | ||
<link rel="stylesheet" type="text/css" href="../../css/sources.css" class="remove"/> | ||
</head> | ||
<body> | ||
<h1>Section panels that scroll horizontally are designed to fit within a width of 320 CSS pixels on a vertically scrolling page</h1> | ||
<section class="meta"> | ||
<p class="id">ID: G225</p> | ||
<p class="technology">Technology: general</p> | ||
<p class="type">Type: Technique</p> | ||
</section> | ||
<section id="applicability"> | ||
<h2>When to Use</h2> | ||
<p>All technologies.</p> | ||
</section> | ||
<section id="description"> | ||
<h2>Description</h2> | ||
<p>The objective of this technique is to ensure that users can zoom in on text within a horizontally scrolling section, while not requiring horizontal scrolling to read the content of each individual panel. Although the entire section requires horizontal scrolling to navigate between panels, each panel is designed to fit within a fixed width of 320 CSS pixels. This ensures that when a 320 CSS pixel wide viewport is used, and the card is in the viewport, each card will remain fully visible without the need for additional horizontal scrolling to read its content.</p> | ||
</section> | ||
<section id="examples"> | ||
<h2>Examples</h2> | ||
<section class="example"> | ||
<h3>A product carousel</h3> | ||
<p>The homepage of an online retail website includes several informational sections, some of which feature carousels showcasing highlighted products. These carousels require horizontal scrolling and have a computed height greater than 256 CSS pixels. Each panel is 320 CSS pixels wide, allowing users to see the full width of the card without horizontal scrolling. Consequently, users only need to scroll vertically to view the entire card, ensuring compliance with success criterion 1.4.10 Reflow for that section.</p> | ||
<p>Working example: <a href="../../working-examples/reflow-carousel-panel-horizontal-scroll/">Carousel panels that scroll horizontally are designed to fit within a width of 320 CSS pixels on a vertically scrolling page</a>. | ||
</section> | ||
</section> | ||
<section id="tests"> | ||
<h2>Tests</h2> | ||
<section class="procedure"> | ||
<h3>Procedure</h3> | ||
<ol> | ||
<li>Check that the layout includes sections of content that scroll horizontally within a vertically scrolling page.</li> | ||
<li>Check that each horizontally scrolling section is divided into distinct panels.</li> | ||
<li>Open the webpage in a user agent that supports 400% zoom, setting the viewport dimensions to 1280 CSS pixels in width.</li> | ||
<li>Activate the zoom function to enlarge the view by 400%.</li> | ||
<li>Check that the content of each individual panel within the horizontally scrolling sections is fully readable without the need for additional horizontal scrolling.</li> | ||
</ol> | ||
<div class="note"> | ||
<p class="note-title marker">Note</p> | ||
<div> | ||
<p>The native browser scrollbar is not included in the viewport dimensions. Therefore, when setting the view to 1280 CSS pixels wide for a vertically scrolling page, make sure to exclude the scrollbar width.</p> | ||
</div> | ||
</div> | ||
</section> | ||
<section class="results"> | ||
<h3>Expected Results</h3> | ||
<ul> | ||
<li>All checks above are true.</li> | ||
</ul> | ||
</section> | ||
</section> | ||
<section id="related"> | ||
<h2>Related Techniques</h2> | ||
<ul> | ||
<li><a href="../general/G206">G206</a></li> | ||
<li><a href="../client-side-script/SCR34">SCR34</a></li> | ||
</ul> | ||
</section> | ||
</body> | ||
</html> |
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.