-
Notifications
You must be signed in to change notification settings - Fork 320
2.4.6-headings-and-labels-descriptive-icons #4147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
9b47bec
2.4.6-headings-and-labels-descriptive-icons
detlevhfischer 150f22b
Update headings-and-labels.html
detlevhfischer ddde778
Update headings-and-labels.html
detlevhfischer 9f86757
Update headings-and-labels.html
detlevhfischer cb6f62d
Update headings-and-labels.html
detlevhfischer 36cceff
Update headings-and-labels.html
detlevhfischer 99a9d42
Update understanding/20/headings-and-labels.html
detlevhfischer c8c0d9c
Update understanding/20/headings-and-labels.html
detlevhfischer 047cc48
Update understanding/20/headings-and-labels.html
detlevhfischer a9e2ef7
Update headings-and-labels.html
detlevhfischer c768199
Update understanding/20/headings-and-labels.html
mbgower f0296bf
Merge branch 'main' into detlevhfischer-patch-1
mbgower 436e537
Update understanding/20/headings-and-labels.html
mbgower 9f1f34b
Update understanding/20/headings-and-labels.html
alastc 0e3250e
Update understanding/20/headings-and-labels.html
alastc a63907e
Update understanding/20/headings-and-labels.html
alastc 9bd0b4c
Merge branch 'main' into detlevhfischer-patch-1
scottaohara 73c9310
Merge branch 'main' into detlevhfischer-patch-1
patrickhlauke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A visible text alternative is also needed. Can we please add an according sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this the whole point of this PR? clarifying that if an icon is "descriptive" enough, it doesn't need text?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is explicity stated: "In some cases, images can serve as descriptive labels without additional text."
Such an image needs a text alternative, but the author does not need to make the alternative visible, just programmatically available (which can be exposed to users in a number of ways, including visibly, through user agents and AT)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patrickhlauke does this work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This addition would make it seem like all instances of images directly need to have alt text, when in reality the image could have no alt text because the form field’s accname is clear enough. Eg having a search icon with alt=search next to a text field with an accname of search is not what anyone should think they need to do in this situation.
To put it bluntly, this just seems to make this more complicated, and to provide the appropriate nuance, it’d submit more verbiage is necessary.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's the text input that needs an accessible name, not the icon/image used as visual label, basically. (which would cross-reference 4.1.2 and, depending how you look at it, 1.1.1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, sorry I missed that. In that case, its basically only 4.1.2 that is needed not 1.1.1.