-
Notifications
You must be signed in to change notification settings - Fork 320
Suggested additional note for focus-not-obscured (AAA), tweak AA note #4403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a9011c2
Suggested additional note for focus-not-obscured (AAA)
patrickhlauke 64c07c3
Merge branch 'main' into patrickhlauke-AAA-follow-up-to-4104
patrickhlauke 520c6ee
Add "fully" to the note in both AA and AAA
patrickhlauke a4fecfd
Merge branch 'main' into patrickhlauke-AAA-follow-up-to-4104
patrickhlauke 202e621
Merge branch 'main' into patrickhlauke-AAA-follow-up-to-4104
mbgower File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight wording changes to improve readability and to match the wording to the context of the AAA requirement.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it makes sense to change that here. It matches the wording we already agreed on and used in the AA note #4104 and doesn't need changing for the AAA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't think it's more readable with the changes, okay. But if you think the mild editorial tweaks improve readability, maybe we should upgrade the AA at the same time. I think we should definitely consider the final change for "fully", as this is only likely to cause a failure of 2.4.7 if the focus indicator is fully obscured, no?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the AA note didn't include "fully" https://github.com/w3c/wcag/pull/4104/files so yes that would need to be patched there too to keep them in line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done the "fully" to both AA and AAA, tweaked the PR description accordingly