Skip to content

Add missing meta charset and remove editors stylesheet at build time #4513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 25, 2025
Merged

Add missing meta charset and remove editors stylesheet at build time #4513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c87161d
Add missing meta charset and remove editors stylesheet at build time
kfranqueiro Jul 31, 2025
0195ab2
Update CustomLiquid notes, since the previous note is no longer relevant
kfranqueiro Jul 31, 2025
543bcf1
Merge branch 'main' into kgf-head-fixes
patrickhlauke Aug 22, 2025
d1154e8
Merge branch 'main' into kgf-head-fixes
mbgower Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions 11ty/CustomLiquid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,8 @@ export class CustomLiquid extends Liquid {

// Clean out elements to be removed
// (e.g. editors.css & sources.css, and leftover template paragraphs)
// NOTE: some paragraphs with the "instructions" class actually have custom content,
// but for now this remains consistent with the XSLT process by stripping all of them.
$(".remove, section#meta, section.meta").remove();
// Note: the link selector accounts for ~40 files forgetting class="remove" on editors.css
$(".remove, link[href$='editors.css'], section#meta, section.meta").remove();

if ($("p.instructions").length > 0) {
console.error(`${filepath} contains a <p class="instructions"> element.\n` +
Expand All @@ -151,6 +150,9 @@ export class CustomLiquid extends Liquid {
throw new Error("Instructions paragraph found; please resolve.")
}

// Add charset to pages that forgot it
if (!$("meta[charset]").length) $('<meta charset="UTF-8">').prependTo("head");

const prependedIncludes = ["header"];
const appendedIncludes = ["wai-site-footer", "site-footer"];

Expand Down
3 changes: 2 additions & 1 deletion techniques/technique-template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<title>Technique Title</title>
<link rel="stylesheet" type="text/css" href="../../css/editors.css">
<link rel="stylesheet" type="text/css" href="../../css/editors.css" class="remove">
</head>
<body>
<h1>Technique Title</h1>
Expand Down
3 changes: 2 additions & 1 deletion understanding/understanding-template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<title>WCAG 2 Understanding Page</title>
<link rel="stylesheet" type="text/css" href="sources.css">
<link rel="stylesheet" type="text/css" href="sources.css" class="remove">
</head>
<body>
<h1>Understanding SC #.#.#</h1>
Expand Down