Remove unnecessary classes from inline code tags #4621
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes classes from
code
elements that appear inline within prose.These classes have no effect, and based on local testing, it would be unrealistic to expect highlight.js to provide meaningful syntax highlighting in the vast majority of these cases due to insufficient context. See #4611 (comment) for more details.
I have looked over this changeset and also ran screenshot diffs; this causes no visible changes.
I did not use global find/replace to perform these changes, since it would be non-trivial to make that skip
<pre ...>...<code class="...">
cases, which this intentionally leaves intact. Instead, I made a script using cheerio (the same library the build system uses for transforms):This script resulted in some unrelated changes due to the underlying parse5 library sanitizing HTML. I went through the changeset and backed out any unrelated changes I could find, so this should only include
class="..."
removals within inline<code>
tags.