-
Notifications
You must be signed in to change notification settings - Fork 317
Updated "A document collection" example since obsolete - SC 2.4.2 #4631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the current example because it's simpler and uses the generic heading of "a document collection". I agree it should be improved, and adding "landing page for…" is nice.
I was just looking at this page in the context of WCAG2ICT and thought the "document collection" example needed improvement. I am okay with using APG as that example, and it's nice to have an example with the vertical bars | since that is common nowadays. |
<dd>The descriptive title of an HTML web page is marked up with the <title> element so | ||
that it will be displayed in the title bar of the user agent.</dd> | ||
<dt>A document collection</dt> | ||
<dt>A guide on authoring practices</dt> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<dt>A guide on authoring practices</dt> | |
<dt>A multi-page guide on authoring practices</dt> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need the simple titular category of "a document collection" or "set of web pages"
<li>Appendix C has the title "References."</li> | ||
<li> | ||
The patterns list page has the title "Patterns | APG | WAI | W3C" | ||
<ul> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's unnecessary and confusing to use nested (and then nested again, 3 levels) bullet points here. I get that the intention here is to also show hierarchy, but a simple straightforward set of bullet points will work best here I'd say
@giacomo-petri I took the liberty to move this back to "In Progress" but please be encouraged to put it under "For Discussion" if you would like feedback from the group. |
Closes #3803
Description:
The current example does not accurately reflect the WCAG title structure and causes considerable confusion. Additionally, self-referential examples are difficult to maintain. For these reasons, I have replaced it with a static example.
Preview: https://deploy-preview-4631--wcag2.netlify.app/understanding/page-titled