Use the duplicate attribute flag is nonceable check #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
Dec 14, 2018
| for: WorkerGlobalScope | ||
| text: owner set; url: concept-WorkerGlobalScope-owner-set | ||
| text: process the iframe attributes; url: process-the-iframe-attributes | ||
| text: duplicate attribute flag; url: concept-script-duplicate-attribute |
There was a problem hiding this comment.
This should not be needed. Whenever you need this it's really a bug of sorts.
ciaramcmullin
added
the
blocked
|
Can't change this unless the HTML issue is resolved |
|
Did this ship in an implementation? Does it need to apply to cc @zcorpan |
|
Firefox (and Chrome according to me comments) only apply the "Is element nonceable?" check to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to be re-checked after whatwg/html#4223 lands
Related issue whatwg/html#3257
Preview | Diff