Change x-frame-options obsoletes wording #702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 23, 2025
annevk
approved these changes
Jan 23, 2025
|
Thanks! Fyi, the build problem should be fixed by #703. |
Thanks updated that branch now that's merged in. And all passing now. So think this is good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at whatwg/html#10936 (comment) "obsoletes" seems to be being misconstrued to mean X-Frame-Options should no longer be used when that was not the intent.
So I'm suggesting "overrides" as a better word? Or could go with "supplants" or "supersedes" (though they may have same issue as "obsoletes")?
Preview | Diff