Fix URL in report-uri request #731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The endpoint variable appears to be unused. Looking at the creation of the request, I think the intention was to use it in the URL. That's also what other browsers appear to be doing.
|
Thanks! This LGTM, I wonder about the failing check, since very strictly speaking this seems a substantive change - although I would consider it a bugfix. I'll wait for someone else to chime in. |
antosart
approved these changes
Jun 2, 2025
|
This is a small-enough fix that I think I'll just assert that it contains no editorial IP. Thanks for the PR! |
github-actions bot
added a commit
that referenced
this pull request
Jun 2, 2025
SHA: 5c12cbb Reason: push, by mikewest Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
A typo that survived 8 years in the specification 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The endpoint variable appears to be unused. Looking at the creation of the request, I think the intention was to use it in the URL. That's also what other browsers appear to be doing.
Preview | Diff