Fix incorrect ASN.1 encoding in android-key test vector#2378
Open
Fix incorrect ASN.1 encoding in android-key test vector#2378
Conversation
The `attestationSecurityLevel` and `keymintSecurityLevel` values in the `attestation` extension (OID `1.3.6.1.4.1.11129.2.1.17`) of the attestation certificate were incorrectly encoded as INTEGER type, but should be ENUMERATED type. See: #2373
arnar
approved these changes
Jan 14, 2026
MasterKale
approved these changes
Jan 14, 2026
|
Hi @emlun, I'm planning to submit a follow-up PR to fix another issue I found in the Android Key Attestation vectors. Since my changes will touch the same lines as this PR, I would prefer to base my work on top of your fix to avoid merge conflicts. Do you have a rough idea of when this might be merged into Thanks ! |
Member
Author
|
You don't need to wait for this to be merged, you're welcome to base your change on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
attestationSecurityLevelandkeymintSecurityLevelvalues in theattestationextension (OID1.3.6.1.4.1.11129.2.1.17) of the attestation certificate were incorrectly encoded as INTEGER type, but should be ENUMERATED type.Fixes #2373.
Preview | Diff