Skip to content

fix(session.ProxyConfiguration): make it a group to allow group choices #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(session.ProxyConfiguration): make it a group to allow group choices #920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1713,13 +1713,13 @@ with parameter |value| is:
[=remote end definition=] and [=local end definition=]

<pre class="cddl remote-cddl local-cddl">
session.ProxyConfiguration = {
session.ProxyConfiguration = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think with this change we will be loosing the type information for the proxy field in session.CapabilityRequest. Instead, I think we can wrap the group choice into an extra () to make sure it is a group.

session.AutodetectProxyConfiguration //
session.DirectProxyConfiguration //
session.ManualProxyConfiguration //
session.PacProxyConfiguration //
session.SystemProxyConfiguration
}
)

session.AutodetectProxyConfiguration = (
proxyType: "autodetect",
Expand Down