Skip to content

Conversation

@carlosjeurissen
Copy link
Contributor

@carlosjeurissen carlosjeurissen commented Dec 22, 2025

This changes the reasons to the present simple as agreed during the 2025-12-18 meeting to align with runtime.onInstalledReason

This PR also adds the browser_update and shared_module_update reasons.

Alternatively we could also add these reasons to runtime.onInstalledReason and use it for onExtensionLoaded as well.

@oliverdunk when this gets implemented in Chrome, is Google in favour of using browser_update instead of chrome_update as reason at least in the onExtensionLoaded event?

@oliverdunk once merged we should update https://issues.chromium.org/issues/41486131

Lastly, there is open discussion on what should happen if multiple reasons apply. See:
#353 (comment)

//
// 'browser_update': The browser was updated to a new version.
//
// 'shared_module_update': Another extension, which contains a module used by this extension, was updated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, shared modules are a Chrome-only concept (and aren't currently supported for extensions in the Chrome Web Store). @Rob--W / @xeenon: Is there any interest in mentioning those here or should we just make that an additional Chrome-specific reason?

@oliverdunk
Copy link
Member

@oliverdunk when this gets implemented in Chrome, is Google in favour of using browser_update instead of chrome_update as reason at least in the onExtensionLoaded event?

I'll reach out to Devlin about this and follow-up. I assume we will be supportive though :)

@oliverdunk
Copy link
Member

I'll reach out to Devlin about this and follow-up. I assume we will be supportive though :)

Confirming that we are ok using browser_update for new events. We don't plan to change any existing ones in the short term.

@carlosjeurissen carlosjeurissen changed the title Update runtime.onLoadedReason to be a superset of runtime.OnInstalledReason Update runtime.onLoadedReason to match runtime.OnInstalledReason Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants