feat: add support for parsing async_sequence<T> type
#775
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,7 +75,9 @@ export class Attribute extends Base { | |
| yield* this.extAttrs.validate(defs); | ||
| yield* this.idlType.validate(defs); | ||
|
|
||
| if ( | ||
| ["async iterable", "sequence", "record"].includes(this.idlType.generic) | ||
|
||
| ) { | ||
| const message = `Attributes cannot accept ${this.idlType.generic} types.`; | ||
| yield validationError( | ||
| this.tokens.name, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,24 @@ | ||
| (attr-invalid-type) Validation error at line 3 in invalid-attribute.webidl, inside `interface sequenceAsAttribute -> attribute invalid`: | ||
| attribute sequence<short> invalid; | ||
| ^ Attributes cannot accept sequence types. | ||
| (attr-invalid-type) Validation error at line 9 in invalid-attribute.webidl, inside `interface asyncIterableAsAttribute -> attribute invalid`: | ||
| async iterable<short> invalid; | ||
| ^ Attributes cannot accept async iterable types. | ||
| (attr-invalid-type) Validation error at line 15 in invalid-attribute.webidl, inside `interface recordAsAttribute -> attribute invalid`: | ||
| <DOMString, DOMString> invalid; | ||
| ^ Attributes cannot accept record types. | ||
| (attr-invalid-type) Validation error at line 23 in invalid-attribute.webidl, inside `interface dictionaryAsAttribute -> attribute dict`: | ||
| attribute Dict dict; | ||
| ^ Attributes cannot accept dictionary types. | ||
| (attr-invalid-type) Validation error at line 24 in invalid-attribute.webidl, inside `interface dictionaryAsAttribute -> attribute dictUnion`: | ||
| attribute (Dict or boolean) dictUnion | ||
| ^ Attributes cannot accept dictionary types. | ||
| (attr-invalid-type) Validation error at line 34 in invalid-attribute.webidl, inside `interface EnforceRangeInReadonlyAttribute -> attribute readOnlyAttr1`: | ||
| readonly attribute [EnforceRange] long readOnlyAttr1; | ||
| ^ Readonly attributes cannot accept [EnforceRange] extended attribute. | ||
| (attr-invalid-type) Validation error at line 35 in invalid-attribute.webidl, inside `interface EnforceRangeInReadonlyAttribute -> attribute readOnlyAttr2`: | ||
| readonly attribute [EnforceRange] GPUInt32In readOnlyAttr2; | ||
| ^ Readonly attributes cannot accept [EnforceRange] extended attribute. | ||
| (attr-invalid-type) Validation error at line 36 in invalid-attribute.webidl, inside `interface EnforceRangeInReadonlyAttribute -> attribute readOnlyAttr2`: | ||
| readonly attribute GPUInt32 readOnlyAttr2; | ||
| ^ Readonly attributes cannot accept [EnforceRange] extended attribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| (operation-return-invalid-type) Validation error at line 1 in invalid-callback-argument.webidl, inside `callback DoSomething -> argument bool`: | ||
| async iterable<DOMString> bool); | ||
| ^ Callback function arguments can not be async iterable types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| callback DoSomething = Promise<DOMString> (async iterable<DOMString> bool); |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,200 @@ | ||
| [ | ||
| { | ||
| "type": "interface", | ||
| "name": "Canvas", | ||
| "inheritance": null, | ||
| "members": [ | ||
| { | ||
| "type": "operation", | ||
| "name": "drawPolygonAsync", | ||
| "idlType": { | ||
| "type": "return-type", | ||
| "extAttrs": [], | ||
| "generic": "Promise", | ||
| "nullable": false, | ||
| "union": false, | ||
| "idlType": [ | ||
| { | ||
| "type": "return-type", | ||
| "extAttrs": [], | ||
| "generic": "", | ||
| "nullable": false, | ||
| "union": false, | ||
| "idlType": "undefined" | ||
| } | ||
| ] | ||
| }, | ||
| "arguments": [ | ||
| { | ||
| "type": "argument", | ||
| "name": "coordinates", | ||
| "extAttrs": [], | ||
| "idlType": { | ||
| "type": "argument-type", | ||
| "extAttrs": [], | ||
| "generic": "async iterable", | ||
| "nullable": false, | ||
| "union": false, | ||
| "idlType": [ | ||
| { | ||
| "type": "argument-type", | ||
| "extAttrs": [], | ||
| "generic": "", | ||
| "nullable": false, | ||
| "union": false, | ||
| "idlType": "float" | ||
| } | ||
| ] | ||
| }, | ||
| "default": null, | ||
| "optional": false, | ||
| "variadic": false | ||
| } | ||
| ], | ||
| "extAttrs": [], | ||
| "special": "" | ||
| } | ||
| ], | ||
| "extAttrs": [], | ||
| "partial": false | ||
| }, | ||
| { | ||
| "type": "interface", | ||
| "name": "I", | ||
| "inheritance": null, | ||
| "members": [ | ||
| { | ||
| "type": "operation", | ||
| "name": "f1", | ||
| "idlType": { | ||
| "type": "return-type", | ||
| "extAttrs": [], | ||
| "generic": "Promise", | ||
| "nullable": false, | ||
| "union": false, | ||
| "idlType": [ | ||
| { | ||
| "type": "return-type", | ||
| "extAttrs": [], | ||
| "generic": "", | ||
| "nullable": false, | ||
| "union": false, | ||
| "idlType": "undefined" | ||
| } | ||
| ] | ||
| }, | ||
| "arguments": [ | ||
| { | ||
| "type": "argument", | ||
| "name": "arg", | ||
| "extAttrs": [], | ||
| "idlType": { | ||
| "type": "argument-type", | ||
| "extAttrs": [], | ||
| "generic": "async iterable", | ||
| "nullable": false, | ||
| "union": false, | ||
| "idlType": [ | ||
| { | ||
| "type": "argument-type", | ||
| "extAttrs": [ | ||
| { | ||
| "type": "extended-attribute", | ||
| "name": "XAttr", | ||
| "rhs": null, | ||
| "arguments": [] | ||
| } | ||
| ], | ||
| "generic": "", | ||
| "nullable": false, | ||
| "union": false, | ||
| "idlType": "float" | ||
| } | ||
| ] | ||
| }, | ||
| "default": null, | ||
| "optional": false, | ||
| "variadic": false | ||
| } | ||
| ], | ||
| "extAttrs": [], | ||
| "special": "" | ||
| } | ||
| ], | ||
| "extAttrs": [], | ||
| "partial": false | ||
| }, | ||
| { | ||
| "type": "interface", | ||
| "name": "asyncIterableReturn", | ||
| "inheritance": null, | ||
| "members": [ | ||
| { | ||
| "type": "operation", | ||
| "name": "stream", | ||
| "idlType": { | ||
| "type": "return-type", | ||
| "extAttrs": [], | ||
| "generic": "async iterable", | ||
| "nullable": false, | ||
| "union": false, | ||
| "idlType": [ | ||
| { | ||
| "type": "return-type", | ||
| "extAttrs": [], | ||
| "generic": "", | ||
| "nullable": false, | ||
| "union": false, | ||
| "idlType": "short" | ||
| } | ||
| ] | ||
| }, | ||
| "arguments": [ | ||
| { | ||
| "type": "argument", | ||
| "name": "foo", | ||
| "extAttrs": [], | ||
| "idlType": { | ||
| "type": "argument-type", | ||
| "extAttrs": [], | ||
| "generic": "async iterable", | ||
| "nullable": false, | ||
| "union": false, | ||
| "idlType": [ | ||
| { | ||
| "type": "argument-type", | ||
| "extAttrs": [], | ||
| "generic": "", | ||
| "nullable": false, | ||
| "union": false, | ||
| "idlType": "short" | ||
| } | ||
| ] | ||
| }, | ||
| "default": null, | ||
| "optional": false, | ||
| "variadic": false | ||
| } | ||
| ], | ||
| "extAttrs": [], | ||
| "special": "" | ||
| } | ||
| ], | ||
| "extAttrs": [ | ||
| { | ||
| "type": "extended-attribute", | ||
| "name": "Exposed", | ||
| "rhs": { | ||
| "type": "identifier", | ||
| "value": "Window" | ||
| }, | ||
| "arguments": [] | ||
| } | ||
| ], | ||
| "partial": false | ||
| }, | ||
| { | ||
| "type": "eof", | ||
| "value": "" | ||
| } | ||
| ] |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| interface Canvas { | ||
| Promise<undefined> drawPolygonAsync(async iterable<float> coordinates); | ||
| }; | ||
|
|
||
| interface I { | ||
| Promise<undefined> f1(async iterable<[XAttr] float> arg); | ||
| }; | ||
|
|
||
| [Exposed=Window] | ||
| interface asyncIterableReturn { | ||
| async iterable<short> stream(async iterable<short> foo); | ||
| }; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.