Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 11, 2024

⚠ NEVER add commits to this pull request.

πŸ€– This pull request was automatically created to facilitate human review of @webref/idl changes triggered by curated data at 1e2699e.

🧐 Please review the diff below and version numbers. If all looks good, merge this pull request to release the changes to npm.

πŸ“¦ Latest released @webref/idl package was v3.55.2. Merging this pull request will release v3.55.3. Make sure that the bump is the right one for the changes.

✍ If any change needs to be made before release, do not add a commit to this pull request. Changes should rather be handled in a separate pull request and pushed to the main branch. You may leave this pull request open in the meantime, or close it. The pre-release job will automatically update this pull request or create a new one once the updates have made their way to the main branch.

πŸ›ˆ The actual change introduced by this pull request is a version bump in packages/idl/package.json. You do not need to review that change. The bumped version is not the version that will be released when this pull request is merged, but rather the version that will be released next time.

diff --ignore-trailing-space '--exclude=package.json' '--exclude=README.md' '--exclude=CHANGELOG.md' '--unified=3' webref/node_modules/@webref/idl/turtledove.idl packages/idl/turtledove.idl
--- webref/node_modules/@webref/idl/turtledove.idl
+++ packages/idl/turtledove.idl
@@ -15,6 +15,7 @@
 
   USVString buyerReportingId;
   USVString buyerAndSellerReportingId;
+  sequence<USVString> selectableBuyerAndSellerReportingIds;
   sequence<USVString> allowedReportingOrigins;
   DOMString adRenderId;
 };
@@ -89,16 +90,16 @@
   sequence<USVString> interestGroupBuyers;
   Promise<any> auctionSignals;
   Promise<any> sellerSignals;
-  Promise<DOMString> directFromSellerSignalsHeaderAdSlot;
-  Promise<record<USVString, USVString>> deprecatedRenderURLReplacements;
+  Promise<DOMString?> directFromSellerSignalsHeaderAdSlot;
+  Promise<record<USVString, USVString>?> deprecatedRenderURLReplacements;
   unsigned long long sellerTimeout;
   unsigned short sellerExperimentGroupId;
-  Promise<record<USVString, any>> perBuyerSignals;
-  Promise<record<USVString, unsigned long long>> perBuyerTimeouts;
-  Promise<record<USVString, unsigned long long>> perBuyerCumulativeTimeouts;
+  Promise<record<USVString, any>?> perBuyerSignals;
+  Promise<record<USVString, unsigned long long>?> perBuyerTimeouts;
+  Promise<record<USVString, unsigned long long>?> perBuyerCumulativeTimeouts;
   unsigned long long reportingTimeout;
   USVString sellerCurrency;
-  Promise<record<USVString, USVString>> perBuyerCurrencies;
+  Promise<record<USVString, USVString>?> perBuyerCurrencies;
   record<USVString, unsigned short> perBuyerMultiBidLimits;
   record<USVString, unsigned short> perBuyerGroupLimits;
   record<USVString, unsigned short> perBuyerExperimentGroupIds;
@@ -198,6 +199,7 @@
   DOMString bidCurrency;
   (DOMString or AdRender) render;
   any ad;
+  USVString selectedBuyerAndSellerReportingId;
   sequence<(DOMString or AdRender)> adComponents;
   double adCost;
   unrestricted double modelingSignals;
@@ -294,6 +296,7 @@
   USVString componentSeller;
 
   USVString buyerAndSellerReportingId;
+  USVString selectedBuyerAndSellerReportingId;
 };
 
 dictionary ReportResultBrowserSignals : ReportingBrowserSignals {

@github-actions github-actions bot force-pushed the release-idl-20241011185343814 branch 12 times, most recently from f3ed066 to f21c840 Compare October 15, 2024 01:01
@github-actions github-actions bot force-pushed the release-idl-20241011185343814 branch from f21c840 to 3baa238 Compare October 18, 2024 07:48
@tidoust tidoust merged commit b4e86f1 into main Oct 18, 2024
@tidoust tidoust deleted the release-idl-20241011185343814 branch October 18, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants