Add a validation guarantee to curated CDDL extracts #1422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dontcallmedom
approved these changes
Dec 20, 2024
|
I just merged w3c/at-driver#85, so if that's been a blocker here, it's clear now. |
This leverages CDDL validation in Strudy to provide a validation guarantee to curated CDDL extracts. A `cddlpatches` folder, which will hopefully remain empty, gets added so that we may temporarily patch CDDL extracts that become invalid.
Bumping the version of Strudy brings new Web IDL anomaly types: - `noEvent` needs events data that is not included in the data we pass to the study function. It must be ignored. - `urlType` is new and we probably don't want to block curation because of it, at least for now (or we're going to have a lot of patching to do...)
dontcallmedom
force-pushed
the
cddl-validation
branch
from
1fa5490 to
0c4843b
Compare
|
the tests now pass \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leverages CDDL validation in Strudy to provide a validation guarantee to curated CDDL extracts, see #1417.
A
cddlpatchesfolder, which will hopefully remain empty, gets added so that we may temporarily patch CDDL extracts when they become invalid.The PR is ready for review, but CDDL extracts in Webref are invalid for now. CDDL extracts from the permissions spec should become valid with next crawl. CDDL extracts from the at-driver depend on w3c/at-driver#85. I suggest to leave this PR pending until the extracts in Webref become valid, not to have to start with adding patches.