Replace most CSS tests by analysis with Strudy #1561
Merged
+464
−730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strudy now integrates a set of analyses that were previously done in Webref. It also extends slightly the duplication guarantees, which used to be restricted to properties. This update replaces most tests with running Strudy. What remains is tests that assess that syntaxes can be parsed with css-tree. These validity tests would better be done in Strudy too in practice, but that's not yet the case. Note: This will report two new problems that need fixing (duplicate type constructs in `css-color-5` and `css-color-hdr`). To be addressed with a patch.
This moves the check on delta specs after the core superseding logic so that delta specs also get checked for actual duplicates with unrelated specs.
I improved the de-duplication logic accordingly. |
dontcallmedom
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strudy now integrates a set of analyses that were previously done in Webref. It also extends slightly the duplication guarantees, which used to be restricted to properties.
This update replaces most tests with running Strudy. What remains is tests that assess that syntaxes can be parsed with css-tree. These validity tests would better be done in Strudy too in practice, but that's not yet the case.
Note: This will report two new problems that need fixing (duplicate type constructs in
css-color-5andcss-color-hdr). To be addressed with some sort of patch. I'll look into it an add another commit to this pull request.