Add a few tests on consolidated CSS file #1569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds tests to guarantee that entries are unique in the consolidated CSS file (they should be by construction, tests are meant to capture bugs that we might miss if we update the consolidation logic in Reffy). Consolidation amends syntaxes of some of the entries. Tests also make sure that syntaxes can be parsed with CSSTree.
test/css/consolidated.js
Outdated
Comment on lines
12
to
20
| atrules: { singular: 'at-rule', plural: 'at-rules' }, | ||
| functions: { singular: 'function', plural: 'functions' }, | ||
| properties: { singular: 'property', plural: 'properties' }, | ||
| selectors: { singular: 'selector', plural: 'selectors' }, | ||
| types: { singular: 'type', plural: 'types' } | ||
| }; | ||
|
|
||
| describe(`The consolidated CSS file`, async () => { | ||
| for (const [category, { singular, plural }] of Object.entries(categories)) { |
There was a problem hiding this comment.
Suggested change
| atrules: { singular: 'at-rule', plural: 'at-rules' }, | |
| functions: { singular: 'function', plural: 'functions' }, | |
| properties: { singular: 'property', plural: 'properties' }, | |
| selectors: { singular: 'selector', plural: 'selectors' }, | |
| types: { singular: 'type', plural: 'types' } | |
| }; | |
| describe(`The consolidated CSS file`, async () => { | |
| for (const [category, { singular, plural }] of Object.entries(categories)) { | |
| ```suggestion | |
| atrules: { singular: 'at-rule' }, | |
| functions: { singular: 'function' }, | |
| properties: { singular: 'property', plural: 'properties' }, | |
| selectors: { singular: 'selector' }, | |
| types: { singular: 'type' } | |
| }; | |
| describe(`The consolidated CSS file`, async () => { | |
| for (const [category, { singular, plural = singular + 's' }] of Object.entries(categories)) { |
if we're being pedantic, let's at least be lazy about it :)
There was a problem hiding this comment.
I pushed a lazier version that avoids the destructuring syntax with a default value, which always makes me pose. Coz' DRY is fine but KISS too!
dontcallmedom
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests to guarantee that entries are unique in the consolidated CSS file (they should be by construction, tests are meant to capture bugs that we might miss if we update the consolidation logic in Reffy).
Consolidation amends syntaxes of some of the entries. Tests also make sure that syntaxes can be parsed with CSSTree.