Skip to content

Fix installed version to compute diff #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged

Fix installed version to compute diff #1599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tools/prepare-release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ MissingPackageError.prototype = Error.prototype;
async function computeDiff(type) {
const packageName = type.replace(/\d+$/, '');
const majorVersionMatch = type.match(/(\d+)$/);
const majorVersion = majorVersionMatch ? '@' + majorVersionMatch[1] : '';
const majorVersion = majorVersionMatch ? majorVersionMatch[1] : '';

// Install @webref package in tmp folder
// If package is pinned to a major version, we'll use that one.
Expand All @@ -88,12 +88,12 @@ async function computeDiff(type) {
}
}
try {
execSync(`npm install @webref/${packageName}${versionToInstall}`, {
execSync(`npm install @webref/${packageName}@${versionToInstall}`, {
cwd: tmpFolder
});
}
catch (err) {
throw new MissingPackageError(`Package @webref/${packageName}${versionToInstall} does not exist or could not be installed.`);
throw new MissingPackageError(`Package @webref/${packageName}@${versionToInstall} does not exist or could not be installed.`);
}

// Extract released version (will be used in the body of the pre-release PR)
Expand Down