Adjust index() in CSS package to also index descriptors
#1624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The consolidated CSS file is mostly flat except for descriptors that are nested under at-rules. The descriptors were still using an array. For consistency, the `index()` function now indexes them by name too. README was also updated to drop the note on at-rules syntax expansion since we no longer do that. It also notes that the list of descriptors is not guaranteed to be exhaustive.
tidoust
force-pushed
the
adjust-css-index
branch
from
012910c to
ecf2c18
Compare
Member
|
the schema expects |
Member
Author
|
Doh, I was pretty sure I had looked at the schema! |
Member
Author
|
Schema updated (tests will keep on failing for a few unrelated reasons though) |
dontcallmedom
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The consolidated CSS file is mostly flat except for descriptors that are nested under at-rules. The descriptors were still using an array. For consistency, the
index()function now indexes them by name too.README was also updated to drop the note on at-rules syntax expansion since we no longer do that. It also notes that the list of descriptors is not guaranteed to be exhaustive.
Draft PR for now because test reveals the need to consolidate descriptors too: some of them get redefined in subsequent levels(Edit: fixed in Reffy).