Update generateKeyFrame to take single optional rid and remove timestamp #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youennf
reviewed
Jul 10, 2025
| 1. Create a pending key frame task called |task| with |task|.`[[rid]]` set to rid and |task|.`[[promise]]`| set to |promise|. | ||
| 1. If |encoder|.`[[pendingKeyFrameTasks]]` is undefined, initialize |encoder|.`[[pendingKeyFrameTasks]]` to an empty set. | ||
| 1. Let |shouldTriggerKeyFrame| be <code>false</code> if |encoder|.`[[pendingKeyFrameTasks]]` contains a task whose `[[rid]]` | ||
| value is equal to |rid|, and <code>true</code> otherwise. | ||
| value is either undefined or equal to |rid|, and <code>true</code> otherwise. |
There was a problem hiding this comment.
It makes undefined a special value and coalescing will not happen between undefined and rid1.
It might be better to coalesce and replace the undefined value by the list of all rids.
|
LGTM in general once we try coalescing calls using undefined and real values. |
youennf
approved these changes
Jul 10, 2025
|
this does not sound like the decision had a valid consensus. |
|
I'll try to split this PR into a couple of pieces to merge the (hopefully) non-controversial parts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143 by aligning with previous decision. Getting this ready for Interop 2025.
Preview | Diff