Skip to content

Update localDescription etc. attributes rather than just their sdp. #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update localDescription etc. attributes rather than just their sdp. #2983

wants to merge 2 commits into from

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Jul 12, 2024 •
edited by pr-preview bot
Loading

Fixes #2977.

Preview | Diff

@jan-ivar jan-ivar requested review from alvestrand, aboba and youennf July 12, 2024 16:22
@jan-ivar jan-ivar self-assigned this Jul 12, 2024
dontcallmedom
dontcallmedom reviewed Jul 12, 2024
View reviewed changes
@jan-ivar jan-ivar added the Needs Test Needs a WPT test label Jul 18, 2024
alvestrand
alvestrand approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@alvestrand alvestrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dontcallmedom dontcallmedom dontcallmedom left review comments

@alvestrand alvestrand alvestrand approved these changes

@aboba aboba Awaiting requested review from aboba

@youennf youennf Awaiting requested review from youennf

Assignees

@jan-ivar jan-ivar

Labels
Editors can integrate Needs Test Needs a WPT test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PC.local_description and friends - snapshot views or dynamic views?
3 participants
@jan-ivar @dontcallmedom @alvestrand