This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Implement 405 for unhandled non-GET requests.#62
Open
kristijanburnik wants to merge 1 commit intow3c:masterfrom
Open
Implement 405 for unhandled non-GET requests.#62kristijanburnik wants to merge 1 commit intow3c:masterfrom
kristijanburnik wants to merge 1 commit intow3c:masterfrom
Conversation
|
Critic review: https://critic.hoppipolla.co.uk/r/5586 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Respond with a
405 Method not allowedfor non-GET requests which don't match a handler.The assumption is that a client is sending a POST/PUT/DELETE request for a resource which is otherwise available via GET, therefore respond with 405.
If a handler is not found and the GET method was used, we assume the resource does not exist (404).
@jgraham