-
Notifications
You must be signed in to change notification settings - Fork 54
Avoid abbreviations for strings and enums #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marcoscaceres
wants to merge
6
commits into
main
Choose a base branch
from
abbrs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3bcaa31
Avoid abbreviations for strings and enums
marcoscaceres c517c9c
Generally avoid abbreviations in naming
marcoscaceres 49bcef7
just point to naming is hard
marcoscaceres d8ce305
Update index.bs
marcoscaceres 4a70295
Update index.bs
marcoscaceres ca03ebf
Update index.bs
marcoscaceres File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -2205,7 +2205,7 @@ is a request, rather than a guarantee. | |||||
Use strings as the values for constants or sets of enumerated values. | ||||||
|
||||||
Strings make it easier for developers to inspect values | ||||||
and read code that uses those values. | ||||||
and read code that uses those values (see [[#naming-is-hard]]). | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this fits better in the first paragraph:
Suggested change
|
||||||
In JavaScript engines there is no performance benefit | ||||||
to using integers instead of strings. | ||||||
The values of a [WebIDL enum type](https://webidl.spec.whatwg.org/#idl-enums) | ||||||
|
@@ -3798,6 +3798,8 @@ API naming *must* be done in easily readable US English. | |||||
Keep in mind that most web developers aren't native English speakers. | ||||||
Whenever possible, names should be chosen that use common vocabulary | ||||||
a majority of English speakers are likely to understand when first encountering the name. | ||||||
Abbreviations should be avoided, | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. https://github.com/w3ctag/process/blob/main/style-guide.md#use-the-active-voice
Suggested change
|
||||||
except in cases where an abbreviation is canonicaland easier to understand. | ||||||
marcoscaceres marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||
|
||||||
<div class="example"> | ||||||
|
||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.