Merged
Conversation
tantek
approved these changes
Mar 13, 2025
csarven
approved these changes
Mar 13, 2025
index.html
Outdated
Comment on lines
68
to
74
| for (const practice of document.querySelectorAll(".practicelab")) { | ||
| if (!practice.id) { | ||
| utils.showWarning( | ||
| `Principle should be assigned an id.`, { elements: [practice] } | ||
| ); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
This might also work? #codeshedding =)
Suggested change
| for (const practice of document.querySelectorAll(".practicelab")) { | |
| if (!practice.id) { | |
| utils.showWarning( | |
| `Principle should be assigned an id.`, { elements: [practice] } | |
| ); | |
| } | |
| } | |
| document.querySelectorAll(".practicelab:not([id])").forEach(practice => { | |
| utils.showWarning( | |
| `Principle should be assigned an id.`, { elements: [practice] } | |
| ); | |
| }); |
Collaborator
Author
There was a problem hiding this comment.
Good point on the :not([id]). I've generally concluded that language-level loops are more readable than the functional-programming methods, when they're not significantly longer, but I'll switch the selector.
github-actions bot
added a commit
that referenced
this pull request
Mar 13, 2025
SHA: 33bd8f3 Reason: push, by jyasskin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this when I wanted to link to one of these, and the ID was a couple lines long.
Preview | Diff