-
Notifications
You must be signed in to change notification settings - Fork 581
LunoKit-Milestone1 #1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LunoKit-Milestone1 #1286
Conversation
|
@Gintma Thanks for the milestone delivery. I’ve evaluated it, and in general, the application is working. However, some improvements to the repository instructions are needed. In addition, a few clarifications regarding the differences between the promised and delivered scope need to be addressed. I’ve evaluated it from the main branch. Please take a look at the evaluation document |
|
@diogo-w3f Thank you for the detailed evaluation. I'd like to address the concerns raised: 1. Documentation & Testing Guide We have added comprehensive documentation to address these issues:
2. Chain Configuration The chain switching functionality is fully accessible in our demo at https://demo.lunolab.xyz/. I'm not sure which version of the demo was reviewed, but the current live version includes a visible chain switching component where users can switch between all supported chains including Polkadot and Paseo AssetHub. Please verify with the latest demo. 3. UI Components Regarding the UI component count, we'd like to clarify our architectural decision: As a wallet connection provider, exposing too many components to external developers is not ideal practice. Internally, our UI module contains 10+ components including:
However, we intentionally expose only essential components (such as Exposing the full internal component set would contradict our goal of providing a simple, developer-friendly API. The internal components are implementation details that support the main public-facing components. We believe this approach better serves our users by maintaining a clean, minimal API surface while delivering all promised functionality. 4. Code Quality |
|
@Gintma Thanks for the answers. While the online documentation looks good, the documentation in the provided repository does not. Please either update the documentation in the repository or provide the repository for your online documentation as a deliverable so that it complies with the license and we can fork it after the milestone approval. Also, please update the milestone delivery document to point the deliverables to the correct links so we can evaluate them properly. Let me know when I can review it again. |
|
@diogo-w3f I've updated the milestone delivery document with the correct links. The documentation source repository is now provided at https://github.com/Luno-lab/lkdoc, which is deployed at https://docs.lunolab.xyz/. |
|
@Gintma thanks for the improvements and fixes. The milestone is accepted. I've added some optional suggestions in the evaluation document. Please take a look. Great work! |
|
🪙 Please fill out the invoice form in order to initiate the payment process. Please make sure that you follow the instructions and requirements as laid out in the form as well as our Terms & Conditions. Thank you! |
|
Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to grantsPR@web3.foundation for feedback on your announcement and cross-promotion. |

Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#2635