Skip to content

Conversation

@Gintma
Copy link
Contributor

@Gintma Gintma commented Oct 9, 2025

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2635

@diogo-w3f diogo-w3f self-assigned this Oct 14, 2025
@diogo-w3f
Copy link
Contributor

@Gintma Thanks for the milestone delivery. I’ve evaluated it, and in general, the application is working. However, some improvements to the repository instructions are needed. In addition, a few clarifications regarding the differences between the promised and delivered scope need to be addressed. I’ve evaluated it from the main branch.

Please take a look at the evaluation document
and provide the necessary answers and fixes. Let me know when I can review it again.

@Gintma
Copy link
Contributor Author

Gintma commented Oct 16, 2025

@diogo-w3f Thank you for the detailed evaluation. I'd like to address the concerns raised:

1. Documentation & Testing Guide

We have added comprehensive documentation to address these issues:

2. Chain Configuration

The chain switching functionality is fully accessible in our demo at https://demo.lunolab.xyz/. I'm not sure which version of the demo was reviewed, but the current live version includes a visible chain switching component where users can switch between all supported chains including Polkadot and Paseo AssetHub. Please verify with the latest demo.
image

3. UI Components

Regarding the UI component count, we'd like to clarify our architectural decision:

As a wallet connection provider, exposing too many components to external developers is not ideal practice. Internally, our UI module contains 10+ components including:

  • ConnectModal
  • ChainModal
  • ConnectButton
  • AccountDetailsModal
  • SpiralAnimation
  • ChainList
  • QRCode
  • Copy
  • ChainIcon
  • Dialog
  • And more...

However, we intentionally expose only essential components (such as ConnectButton, ConnectModal, ChainModal, AccountDetailsModal) to the public API. Our design philosophy is that developers should be able to accomplish account connection, network switching, balance display, and all related operations through just the ConnectButton component.

Exposing the full internal component set would contradict our goal of providing a simple, developer-friendly API. The internal components are implementation details that support the main public-facing components.

We believe this approach better serves our users by maintaining a clean, minimal API surface while delivering all promised functionality.

4. Code Quality
Linting warnings have been addressed and improved.

@diogo-w3f
Copy link
Contributor

@Gintma Thanks for the answers. While the online documentation looks good, the documentation in the provided repository does not. Please either update the documentation in the repository or provide the repository for your online documentation as a deliverable so that it complies with the license and we can fork it after the milestone approval.

Also, please update the milestone delivery document to point the deliverables to the correct links so we can evaluate them properly. Let me know when I can review it again.

@Gintma
Copy link
Contributor Author

Gintma commented Oct 17, 2025

@diogo-w3f I've updated the milestone delivery document with the correct links. The documentation source repository is now provided at https://github.com/Luno-lab/lkdoc, which is deployed at https://docs.lunolab.xyz/.
Please review it again when you have time.

@diogo-w3f
Copy link
Contributor

@Gintma thanks for the improvements and fixes. The milestone is accepted. I've added some optional suggestions in the evaluation document. Please take a look. Great work!

@diogo-w3f diogo-w3f merged commit a1cfb1c into w3f:master Oct 17, 2025
3 checks passed
@github-actions
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Please make sure that you follow the instructions and requirements as laid out in the form as well as our Terms & Conditions. Thank you!

@github-actions
Copy link

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to grantsPR@web3.foundation for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants