Elastic Labs - Polkadot Agent Kit - Milestone 2#1299
Conversation
|
@chungquantin and @tin-thebc thanks for the milestone delivery. I've tried to run the tests but some are failing. Furthermore, I was not able to measure the testing coverage. Please see the evaluation document and provide proper answers and fixes. Let me know when I can test it again. |
|
Due to the recent Asset Hub migration, there have been runtime changes on both Asset Hub and RelayChain that caused several issues: Some public RPCs are unstable.
I have addressed these changes in elasticlabs-org/polkadot-agent-kit#126 . Please checkout the main branch and re-run the tests on both testnet and mainnet. It is working from my side Testnet
Mainnet
|
|
@CocDap thanks for the improvements and fixes. The integration tests now run on testnet. However, they don't show the full requirements for this milestones are met. Please update the tests to be able to show all them. See the details in the evaluation document. Let me know when I can check again. |
|
Hi @diogo-w3f Thank you for the feedback. I have reviewed the current integration tests, and from my perspective, all the requirements appear to be covered by the existing test cases.
->
->
->
Could you please specify which exact requirements from the evaluation document you feel are missing or not clearly demonstrated? This will help me ensure I address the specific gaps you are seeing. |
|
@CocDap I see that some tests are only available on mainnet. Is it possible to make them available on a testnet? This would make our verification easier, since we wouldn’t need mainnet tokens. It’s not usual to use mainnet for testing, in fact. For each test, it would be helpful if you could provide some evidence, such as the transaction hash, so I can verify each transaction on-chain. Please let me know if it will be possible to run all tests on a testnet with the corresponding evidence for verification. Otherwise, advise what tokens we need to have to be able to run these tests. |
|
Hi @diogo-w3f Status Update: Testnet Limitations & Mainnet VerificationCurrently, I am facing some blockers with the Testnet environment, so I have verified the integration on Mainnet instead. 1. Current Issues (Testnet)
2. Mainnet VerificationI have successfully run the integration tests on Mainnet. Below are the transaction hashes for reference:
3. How to Replicate (Mainnet)To replicate these test cases manually against Mainnet, please follow these steps: Prerequisites:
Run command: Full Result:
4. Testnet Verification
|
|
@CocDap thanks for the explanation. I funded this account 13nG3YW4JUe6XdnYiHXiYxzwCQRHvpzHdgUuQP7C3Q5QjMff on mainnet and tried to run the tests but they are failing. Can you help with that: |
|
hi @diogo-w3f . I reproduced the new funded account. it is working properly. This is my testing account: https://assethub-polkadot.subscan.io/account/12Sz5LM2MjA3Cs8eXPLNxNwoqNk5MCrdj2mCsN2yk1Atvty2?tab=extrinsic Can you try to re-run again? Make sure that you have enough balance on Polkadot Asset Hub and Bifrost Did you add your testing private key to .env ( |
|
@CocDap Yes, I've added a private key for mainnet. I was able to run the tests using this address 14xSKfjciBCJjUt7QPyqkZyosnExbFB2qibBfaDFFvtzxN2g and see the effect on chain, however, one test is still failing. Can you check and fix this? |
|
hi @diogo-w3f . i replicated multiple times, it is working properly from my side. I have checked your account again, it seems working now |
|
I hope you enjoyed the holiday break. Would you mind reviewing my comments once more at your convenience? |
|
@CocDap thanks for the explanation. I've checked again and the tests failed due to an assertion that is only in my env. In this way, the milestone is accepted. See the details in the evaluation document. Great work! |
|
🪙 Please fill out the invoice form in order to initiate the payment process. Please make sure that you follow the instructions and requirements as laid out in the form as well as our Terms & Conditions. Thank you! |
|
@diogo-w3f the invoice form https://docs.google.com/forms/d/e/1FAIpQLSfmNYaoCgrxyhzgoKQ0ynQvnNRoTmgApz9NrMp-hd8mhIiO0A/viewform?usp=pp_url&entry.1070766548=https://github.com/w3f/Grant-Milestone-Delivery/pull/1299 is no longer valid, it is closed. What would be the right way to submit an invoice for this? |
|
@chungquantin the form was closed by mistake, now it is open. Please use it to submit your invoice. |












Milestone Delivery Checklist
Link to the application pull request: https://github.com/w3f/Grants-Program/blob/master/applications/polkadot_agent_kit.md < please fill this in with the PR number of your application.