Conversation
|
WalkthroughThe pull request migrates the project's package manager from npm to pnpm. Updates include adding pnpm installation steps to GitHub Actions workflows, switching cache keys to pnpm, replacing npm/npx commands with pnpm equivalents, adding Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (3)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonpnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (6)
.github/workflows/bundlewatch-pr.yml(1 hunks).github/workflows/bundlewatch-push.yml(1 hunks).github/workflows/cd.yml(1 hunks).github/workflows/ci.yml(7 hunks).prettierignore(1 hunks)package.json(2 hunks)
🔇 Additional comments (7)
.prettierignore (1)
7-7: LGTM!Adding
pnpm-lock.yamlto.prettierignoreis correct and follows the same pattern aspackage-lock.jsonfor npm.package.json (2)
81-81: LGTM!The
packageManagerfield withpnpm@10.25.0is correctly set. pnpm 10.25.0 was published 3 days ago, and pnpm 10.25 improves certificate handling, adds a bare pnpm init, and ships several quality-of-life fixes.
104-104: Do not removenpm-run-all2— it is actively used.The
npm-run-all2package is still actively referenced in the build script at package.json line 56:"build": "run-s --silent build:package-info build:lib build:browser build:docs". Therun-sutility is a direct dependency of this package and continues to be used for sequential task execution. Removing it would break the build process..github/workflows/bundlewatch-pr.yml (1)
14-27: LGTM!All pnpm migration changes are correct: pnpm setup step, cache strategy switch, and command substitutions (
pnpm installandpnpm run build)..github/workflows/bundlewatch-push.yml (1)
15-28: LGTM!Consistent with the bundlewatch-pr.yml updates: pnpm setup, cache configuration, and command replacements are all correct.
.github/workflows/cd.yml (1)
29-45: LGTM!All pnpm migration changes are correct, including the proper conversion of
npx pkg-pr-new publishtopnpm dlx pkg-pr-new publish..github/workflows/ci.yml (1)
24-37: LGTM!All workflow jobs are correctly migrated to pnpm: setup steps, cache configuration, and command replacements are consistent throughout. The use of
pnpm dlxforattwandpnpm execfor playwright commands is correct.Note: The
versionandpublishfields in the changesets action (lines 194–195) depend on the scripts being correctly defined in package.json. Given the--silentflag issue identified in package.json, verify that the changeset scripts execute correctly once that issue is resolved.Also applies to: 47-60, 70-86, 99-112, 128-155, 178-195
This pull request migrates the project from npm to pnpm as the primary package manager. It updates all relevant continuous integration and deployment workflows, scripts, and configuration files to use pnpm instead of npm, ensuring a consistent and more efficient dependency management process.
CI/CD Workflow Migration:
ci.yml,cd.yml,bundlewatch-pr.yml,bundlewatch-push.yml) now install and use pnpm for dependency installation, caching, building, and running scripts instead of npm. This includes usingpnpm dlxfor CLI tools and updating the node setup cache to pnpm. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Project Configuration Updates:
package.jsonnow specifies pnpm as the package manager and updates all scripts and pre-scripts to use pnpm commands instead of npm. [1] [2].prettierignorefile is updated to ignore the pnpm lockfile (pnpm-lock.yaml).These changes ensure the project is fully transitioned to pnpm for improved performance and reliability in dependency management.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.