Merged
Conversation
* Refactor project structure and enhance CLI functionality * Enhance CIDR detection across platforms and improve IP validation in GUI * Update README.md * Refactor network functionality by introducing adapters for IP detection and CIDR handling * Update README.md * Add skipping GUI tests in CI without DISPLAY * Add skipping GUI tests in CI without DISPLAY * Fix CI tests * Fix CI tests
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements release 0.1.9 with a significant architectural refactoring of LanCalc. The primary focus is on modularizing the codebase into distinct CLI and GUI components while adding external IP detection capabilities.
Key changes include:
- Modular architecture separating core logic, CLI, GUI, and external adapters
- Added external IP detection with new
-e/--externalCLI flag - Refactored package structure with optional GUI dependencies
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test_lancalc.py | Updated test structure to work with new modular architecture and added network interface detection tests |
| pytest.ini | Added qt_api marker configuration for PyQt5 tests |
| pyproject.toml | Updated dependencies to make PyQt5 required and added nogui optional dependency group |
| lancalc/main.py | Converted to adaptive launcher that detects environment and chooses CLI/GUI mode |
| lancalc/gui.py | New module containing GUI functionality extracted from main.py |
| lancalc/core.py | New module with pure business logic for network calculations |
| lancalc/cli.py | New module handling command-line interface with external IP support |
| lancalc/adapters.py | New module for external system interactions and network detection |
| lancalc/main.py | Added module entry point for python -m lancalc usage |
| lancalc/init.py | Updated to export new modular structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
wachawo
added a commit
that referenced
this pull request
Nov 3, 2025
* Refactor project structure and enhance CLI functionality * Enhance CIDR detection across platforms and improve IP validation in GUI * Update README.md * Refactor network functionality by introducing adapters for IP detection and CIDR handling * Update README.md * Add skipping GUI tests in CI without DISPLAY * Add skipping GUI tests in CI without DISPLAY * Fix CI tests * Fix CI tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.