Redesign TODO test output: separate axis with pending/resolved#728
Merged
Conversation
- TODO tests no longer count as pass/fail; they have their own axis - TodoPending: test trapped as expected (feature still unimplemented) - TodoResolved: test passed unexpectedly (hard failure — must remove #[TODO]) - Summary line: "N passed, N failed; N todo (M resolved)" - TODO summary section at the end lists all TODO tests with status - Exit failure if any TODO tests are resolved (enforces cleanup) - E2E tests: same policy — resolved TODO is a hard failure https://claude.ai/code/session_01Dt11N9EJkrwhjhC7PhMLQG
- Add "Test Outcome Model" section with tables for regular and TODO tests - Specify pending/resolved semantics and exit code rules - Document output format with TODO summary section - Update #[TODO] and #![TODO] attribute descriptions - Update cheatsheet to reflect new TODO semantics https://claude.ai/code/session_01Dt11N9EJkrwhjhC7PhMLQG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[TODO],#![TODO]) are now reported on a separate axis from pass/fail, inspired by TAP's TODO directive#[TODO]when the feature works.N passed, N failed; N todo (M resolved)docs/spec.md(Test Outcome Model section)Motivation
Previously, TODO tests were "expected to fail" — if a compiler fix caused a TODO test to start passing, it showed up as a test failure, which was confusing and made compiler development harder. Now, newly-passing TODO tests appear as "resolved" on the TODO axis instead.
Output example
Test plan
cargo check --bin wadopassescargo check --test e2e -p wado-compilerpassesmise run on-task-done(running)https://claude.ai/code/session_01Dt11N9EJkrwhjhC7PhMLQG