Merged
Conversation
The `store: bool` parameter was a workaround for naming collisions in `dedup_name` — `store=false` generated throwaway `tok` names while `store=true` generated meaningful names like `k_explain`, `comma`, etc. Since all `store=false` call sites are for elements that either use fresh scoped `name_counts` (loop bodies) or don't contribute to struct field assignments, the collision concern doesn't apply. Always using meaningful names is safe and improves generated code readability. https://claude.ai/code/session_01DsE7sSd7BNvctRdNnYXLA3
Elements inside optional/backtrack if-blocks and group if/else branches are scoped, so their dedup counters must not pollute the parent scope. Use fresh name_counts for these scoped blocks to keep parent counters in sync with gen_field_assignments. https://claude.ai/code/session_01DsE7sSd7BNvctRdNnYXLA3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
store: boolparameter fromgen_elementin the Gale parser generator, always generating meaningful variable names (the oldstore=truebehavior)k_explain,comma,database_nameinstead of throwawaytok/tok_2namespackage-gale/TODO.mdBackground
store=falsewas a workaround for naming collisions indedup_name. Allstore=falsecall sites either use fresh scopedname_counts(loop bodies) or don't contribute to struct field assignments, so the collision concern doesn't apply. Always using meaningful names is safe and improves generated code readability.Test plan
wado test package-gale/src)on-task-donepasses (format, clippy, all Rust and Wado tests)https://claude.ai/code/session_01DsE7sSd7BNvctRdNnYXLA3