Rename #[wasi("...")] attribute to #[cm("...")] for general CM support#751
Merged
Rename #[wasi("...")] attribute to #[cm("...")] for general CM support#751
Conversation
… CM support
The wasi attribute was WASI-specific but the CM bridge logic has nothing
WASI-specific. Renaming to #[cm("namespace:pkg/iface...")] makes it
reusable for any Component Model namespace. Also renames #[wasi_params]
to #[cm_params], WasiImport to CmImport, and updates all generated
wasi/*.wado stdlib files. Additionally fixes wado-from-wit to use the
actual package namespace instead of hardcoding "wasi:".
https://claude.ai/code/session_01SAuHAY6kD8V36si1pZ6NCM
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: aaacabc | Previous: 0132b7a | Ratio |
|---|---|---|---|
sieve (-O3) |
133 ms |
62 ms |
2.15 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[wasi("...")]attribute to#[cm("...")]and#[wasi_params(...)]to#[cm_params(...)]so the attribute is reusable for any Component Model namespace, not just WASIWasiImport→CmImport,wasi_import→cm_import,WirWasiImport→WirCmImportwado-from-witto use the actual package namespace from WIT instead of hardcoding"wasi:"wasi/*.wadostdlib files and update docs/fixturesTest plan
on-task-donepasses with 0 failureshttps://claude.ai/code/session_01SAuHAY6kD8V36si1pZ6NCM