Remove highlight_html_page, fix keyword heuristic for K_ rules#778
Merged
Conversation
- Remove highlight_html_page and split_lines from runtime (highlight should return plain HTML spans, not a full page with styles) - Generated highlight() now calls highlight_html() directly - Add keyword classification for lexer rules prefixed with K_ or KW_ (e.g. K_SELECT, KW_IF) — common in ANTLR grammars like SQLite.g4 - Add driver_sqlite_highlight_test.wado with TDD tests for keyword, string, number, comment, punctuation, and operator highlighting - Update all golden files (runtime change propagates to inlined code) https://claude.ai/code/session_01AeL3xUo2isDA6H79bcgC35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
highlight_html_pageandsplit_linesfrom Gale runtime —highlight()now returns plain HTML spans (matching tree-sitter output format), not a full page with styles/line-number tableK_orKW_askeyword(e.g.K_SELECT,KW_IF— common in ANTLR grammars like SQLite.g4)driver_sqlite_highlight_test.wadowith tests for keyword, string, number, comment, punctuation, and operator highlightingTest plan
wado test package-gale/src/runtime_test.wado— 23 passedwado test package-gale/tests/driver_sqlite_highlight_test.wado— 7 passed (keyword tests were red before fix)wado test package-gale/tests/driver_json_highlight_test.wado— 7 passed (no regression)mise run update-gale-goldenhttps://claude.ai/code/session_01AeL3xUo2isDA6H79bcgC35