Skip to content

remove quick and dirty caching #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CypherPotato wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove quick and dirty caching #274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions src/PrettyPrompt/Highlighting/SyntaxHighlighter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,31 +16,19 @@ internal class SyntaxHighlighter
private readonly IPromptCallbacks promptCallbacks;
private readonly bool hasUserOptedOutFromColor;

// quick and dirty caching, mainly to handle cases where the user enters control
// characters (e.g. arrow keys, intellisense) that don't actually change the highlighted input
private string previousInput;
private IReadOnlyCollection<FormatSpan> previousOutput;

public SyntaxHighlighter(IPromptCallbacks promptCallbacks, bool hasUserOptedOutFromColor)
{
this.promptCallbacks = promptCallbacks;
this.hasUserOptedOutFromColor = hasUserOptedOutFromColor;
this.previousInput = string.Empty;
this.previousOutput = Array.Empty<FormatSpan>();
//this.previousInput = string.Empty;
//this.previousOutput = Array.Empty<FormatSpan>();
}

public async Task<IReadOnlyCollection<FormatSpan>> HighlightAsync(string input, CancellationToken cancellationToken)
{
if (hasUserOptedOutFromColor) return Array.Empty<FormatSpan>();

if (input.Equals(previousInput))
{
return previousOutput;
}

var highlights = await promptCallbacks.HighlightCallbackAsync(input, cancellationToken).ConfigureAwait(false);
previousInput = input;
previousOutput = highlights;
return highlights;
}
}