feat: ci 액션에 경로 필터 추가 & 도커 빌드 캐시 추가 #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
ci.yml 수정했는데 안 돌아가는 거 확인 |
Collaborator
Author
This reverts commit f6ff5b5.
woohm402
reviewed
Jul 31, 2024
Member
woohm402
left a comment
woohm402
left a comment
There was a problem hiding this comment.
(사실 저는 개인적으로 *.md 빼고는 뭐가 수정돼도 CI 돌아야 된다고 생각하긴 합니다)
minkyu97
commented
Jul 31, 2024
Comment on lines
+25
to
+35
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
| - name: Build | ||
| uses: docker/build-push-action@v6 | ||
| with: | ||
| context: . | ||
| push: false | ||
| tags: waffle-judge | ||
| cache-from: type=gha | ||
| cache-to: type=gha,mode=max | ||
| outputs: type=docker,dest=/tmp/waffle-judge.tar |
Collaborator
Author
There was a problem hiding this comment.
별도 PR로 올릴까 하다가.. ci 개선이라는 명목으로 퉁쳐서 도커 공식문서에 있는 깃헙 액션 프리셋을 활용하도록 변경했습니다.
당장은 캐시가 없고 앞뒤 준비과정이 있어서 조금 더 느려진 감이 있는데 캐시가 활용되면 더 빨라질 거예요
Collaborator
Author
|
https://github.com/wafflestudio/waffle-judge/actions/runs/10185735551/attempts/1#summary-28175933541 |
Member
|
옹 그럼 지금은 캐시가 올라가 있을 테니 테스트커밋 하나 추가해서 속도 얼마나 개선됐는지 한번 볼 수 있을까요? |
Collaborator
Author
|
뭐야 왜 캐시 작동 안해 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
추가된 기능
ci 액션에 경로 필터를 추가하고 도커 빌드 캐시를 활용하여 시간을 단축시킵니다.
테스트 방법
관련 없는 경로의 파일만 수정한 뒤 PR 올려서 ci 액션 안 돌아가는지 보기
ci 액션 잘 돌아가는지 확인
관련 링크
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore
https://docs.docker.com/build/ci/github-actions/cache/#github-cache