Skip to content

Refactor/consolidate error logic#109

Merged
young-52 merged 5 commits intomainfrom
refactor/consolidate-error-logic
Feb 28, 2026
Merged

Refactor/consolidate error logic#109
young-52 merged 5 commits intomainfrom
refactor/consolidate-error-logic

Conversation

@jun-0411
Copy link
Collaborator

@jun-0411 jun-0411 commented Feb 28, 2026 •
edited
Loading

๐Ÿ“ ์ž‘์—… ๋‚ด์šฉ

  • apiClient๋ฅผ ์ œ์™ธํ•œ ์˜ค๋ฅ˜ ์ฒ˜๋ฆฌ ๋กœ์ง์„ ๋ชจ๋‘ ์ œ๊ฑฐํ–ˆ์Šต๋‹ˆ๋‹ค.
  • hooks์—์„œ ์„ฑ๊ณต ์ฒ˜๋ฆฌ์šฉ ํ† ์ŠคํŠธ ๋กœ์ง์„ ๋ชจ๋‘ ์ œ๊ฑฐํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๊ฐ ํŽ˜์ด์ง€์—์„œ ์„ฑ๊ณต ์ฒ˜๋ฆฌ์šฉ ํ† ์ŠคํŠธ๋ฅผ ๋„์šฐ๋Š” ๊ฒƒ์œผ๋กœ ๋กœ์ง์„ ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท (์„ ํƒ)

๐Ÿš€ ๋ฆฌ๋ทฐ ์š”๊ตฌ์‚ฌํ•ญ (์„ ํƒ)

  • hooks ํด๋”์—์„œ api ์‚ฌ์šฉํ•˜๋Š” ๋ฐฉ์‹์ด ํ†ต์ผ๋˜์–ด์žˆ์ง€ ์•Š์•„ ๋ฆฌํŒฉํ† ๋ง์„ ํ•ด์•ผํ•  ๊ฒƒ ๊ฐ™๊ธด ํ•œ๋ฐ..... ์šฐ์„  ๋‹ค๋ฅธ ์ด์Šˆ๋ถ€ํ„ฐ ์ฒ˜๋ฆฌํ•˜๊ณ  ๋‚˜์ค‘์— ์†๋ด์•ผ๊ฒ ๋„ค์š”...
  • #PR107 ๋ถ€ํ„ฐ ๋จธ์ง€ํ•˜๊ณ , ์ด PR ๋จธ์ง€ํ•ด์ฃผ์‹œ๋ฉด ๊ฐ์‚ฌํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

@jun-0411 jun-0411 requested a review from young-52 February 28, 2026 05:19
@jun-0411 jun-0411 added the bug Something isn't working label Feb 28, 2026
@jun-0411 jun-0411 linked an issue Feb 28, 2026 that may be closed by this pull request
โ™ป๏ธ Consolidate duplicated error handling logic #108
Closed
young-52
young-52 reviewed Feb 28, 2026
View reviewed changes
Copy link
Collaborator

@young-52 young-52 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฆฌ๋ทฐ ์ˆœ์„œ์— ๊ด€ํ•˜์—ฌ

#109 PR๊ฐ€ #107 PR์˜ ๋‚ด์šฉ์„ ๋ชจ๋‘ ํฌํ•จํ•˜๊ณ  ์žˆ์–ด์„œ, #107 PR๋Š” ๋‹ซ์•˜์Šต๋‹ˆ๋‹ค.

์ผ์‹œ ์„ ํƒ UI์— ๊ด€ํ•˜์—ฌ

๋‚ ์งœ์™€ ์‹œ๊ฐ„์„ ์„ ํƒํ•˜๋Š” UI๋ฅผ DateTimePicker์—์„œ ControlledDateTimePicker๋กœ ๋ฐ”๊พธ์‹  ๊ฒƒ์œผ๋กœ ๋ณด์ด๋Š”๋ฐ์š”, ๋ฐ”๊พธ์‹  ์ด์œ ๊ฐ€ ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค.

@jun-0411
Copy link
Collaborator Author

jun-0411 commented Feb 28, 2026

DateTimePicker๊ฐ€ ๋ถˆํŽธํ•˜๋‹ค๋Š” ์˜๊ฒฌ์ด ์žˆ์—ˆ์–ด์„œ, ์บ˜๋ฆฐ๋”์—์„œ ์„ ํƒ๊ณผ ์‹œ๊ฐ„ ์ง์ ‘ ์„ ํƒ์„ ๋ชจ๋‘ ์ง€์›ํ•˜๊ฒŒ ๋ฐ”๊ฟจ์Šต๋‹ˆ๋‹ค.
์ง€๊ธˆ๋„ ์บ˜๋ฆฐ๋” ๋ฒ„ํŠผ์„ ๋ˆ„๋ฅด๋ฉด ์ด์ „์ฒ˜๋Ÿผ ์„ ํƒํ•  ์ˆ˜ ์žˆ๋Š”๋ฐ, ์•ฝ๊ฐ„ ๋น„์ง๊ด€์ ์ด๊ธด ํ•ด์„œ ๊ณ ๋ฏผ์ค‘์ด๊ธด ํ•ฉ๋‹ˆ๋‹ค....

@young-52 young-52 self-requested a review February 28, 2026 12:54
young-52
young-52 approved these changes Feb 28, 2026
View reviewed changes
Copy link
Collaborator

@young-52 young-52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•„ํ•˜! ์บ˜๋ฆฐ๋” ์•„์ด์ฝ˜์„ ๋ˆ„๋ฅด๋‹ˆ ์บ˜๋ฆฐ๋” UI๊ฐ€ ์—ด๋ฆฌ๋„ค์š”. ์ด์ œ์•ผ ๋ฐœ๊ฒฌํ–ˆ์Šต๋‹ˆ๋‹คโ€ฆ
๋ง์”€ํ•˜์‹  ๋Œ€๋กœ ์ง๊ด€์„ฑ์ด ๋ฌธ์ œ์ด๊ธด ํ•œ๋ฐ, ์šฐ์„  ๋ฌธ์ œ ์—†์–ด ๋ณด์—ฌ์„œ ๋ณ‘ํ•ฉํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

@young-52 young-52 merged commit 4162d60 into main Feb 28, 2026
1 check passed
@young-52 young-52 deleted the refactor/consolidate-error-logic branch February 28, 2026 12:56
@young-52 young-52 linked an issue Feb 28, 2026 that may be closed by this pull request
๐Ÿ’„ Update UI for EventEdit page #106
Closed
This was linked to issues Feb 28, 2026
[bug] toast ui ์ค‘๋ณต ํ‘œ์‹œ ๋ฌธ์ œ #86
Closed
์—๋Ÿฌ ํ‘œ์‹œ ๋กœ์ง ํ†ต์ผ #93
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@young-52 young-52 young-52 approved these changes

Assignees

@young-52 young-52

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

2 participants

@jun-0411 @young-52