Refactor QualitativeInput to use raw JSON string#79
Merged
Conversation
Replace complex heuristic-based context extraction with a single raw JSON string containing the full chat session transcript with embedded tool uses. Changes: - QualitativeInput now has a single raw_session field containing JSON - Added SessionTranscript, SessionTurn, and EmbeddedToolUse structs - Implement center-truncation for long tool content (2000 char threshold) - Updated collect_qualitative_data to build JSON transcript from messages - Updated build_qualitative_analysis_prompt to use raw session format - Updated fallback analysis to parse session stats from JSON - Updated TypeScript types for frontend compatibility This provides the LLM with full conversation context including all tool operations, enabling more accurate qualitative analysis.
- Remove generate_quantitative_analysis_fallback and related scoring functions - Remove generate_qualitative_analysis_fallback and SessionStats-based functions - Remove generate_rubric_evaluation_fallback - Update analytics_service to require AI client (error if unavailable) - Update parse_qualitative_response to return Err instead of fallback data - Clean up unused imports Analysis now requires a valid AI client and propagates errors instead of falling back to rule-based analysis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace complex heuristic-based context extraction with a single raw JSON string containing the full chat session transcript with embedded tool uses.
Changes:
This provides the LLM with full conversation context including all tool operations, enabling more accurate qualitative analysis.