DialogFragment 생성 시 매개변수 삭제 #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjshim2003
commented
Aug 9, 2025
| fun onGallerySelected() | ||
| fun onDefaultImageSelected() | ||
| } | ||
|
|
There was a problem hiding this comment.
BottomSheetDialogFragment는 함수 매개변수를 받고 있었기 때문에 리스너를 추가해서 해결했습니다.
Comment on lines
+36
to
+46
| companion object { | ||
| private const val DEFAULT_MODE = "FULL" | ||
|
|
||
| fun newInstance(type: FilterMode): FilterDialogFragment { | ||
| return FilterDialogFragment().apply { | ||
| arguments = Bundle().apply { | ||
| putString(DEFAULT_MODE, type.name) | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
FilterDialog의 경우 enum class인 FilterMode만 받으면 되기 때문에 newInstance를 정의해 주어서 해결했습니다.
kevin990222
approved these changes
Aug 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #150의 문제를 해결하면서 filterdialog까지 수정했습니다.